Closed
Bug 1271049
Opened 8 years ago
Closed 8 years ago
View > Page Style does not show options from <style> elements
Categories
(Firefox :: Menus, defect)
Tracking
()
RESOLVED
FIXED
Firefox 49
People
(Reporter: stanio, Assigned: Gijs)
References
()
Details
(Keywords: regression)
Attachments
(3 files)
355 bytes,
text/html
|
Details | |
413 bytes,
text/html
|
Details | |
58 bytes,
text/x-review-board-request
|
mconley
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
Tried with current Firefox 46 Release and Firefox 48 Developer Edition. Having a page with the following styles defined: <style> body { font-size: 150% } </style> <style title="Green"> body { color: green } </style> <style title="Orange"> body { color: orange } </style> does not show "Green" and "Orange" options in the View > Page Style menu, but just "No Style" and "Basic Page Style" – the later appears preselected. The "Green" style appears applied on fresh load, but selecting "Basic Page Style" over appears to switch the named styles off. The following analogous definitions appear to work as expected: <style> body { font-size: 150% } </style> <link rel="stylesheet" title="Green" href="data:text/css,body { color: green }"> <link rel="stylesheet" title="Orange" href="data:text/css,body { color: orange }"> FWIW, the original case works fine in SeaMonkey 2.43 (Gecko 46). In all cases evaluating |document.styleSheetSets| in the Web Console returns: DOMStringList [ "Green", "Orange" ]
Reporter | ||
Comment 1•8 years ago
|
||
Reporter | ||
Updated•8 years ago
|
Comment 2•8 years ago
|
||
Regression window: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=feef0d9dbf1b030560a6813af32a63fd0f9e9635&tochange=5916ad1372e7c564aa7fbf67ccb895bc4953b6eb Regressed by: Bug 1141041
Blocks: 1141041
status-firefox46:
--- → affected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox49:
--- → affected
status-firefox-esr45:
--- → affected
Flags: needinfo?(mconley)
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: regression
Version: 48 Branch → 44 Branch
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(mconley)
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51359/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51359/
Attachment #8750319 -
Flags: review?(mconley)
Comment 4•8 years ago
|
||
Regression from 44, Looks like we have a fix coming. We could still take this on aurora if it works in m-c and you think it is safe.
Comment 5•8 years ago
|
||
Comment on attachment 8750319 [details] MozReview Request: Bug 1271049 - fix showing alternative styles from <style> elements and make the test actually test things, r?mconley https://reviewboard.mozilla.org/r/51359/#review48765 Good stuff! Thanks for the regression test, and cleaning up the test file while you were at it! You're a superstar.
Attachment #8750319 -
Flags: review?(mconley) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c751c1775268
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8750319 [details] MozReview Request: Bug 1271049 - fix showing alternative styles from <style> elements and make the test actually test things, r?mconley Approval Request Comment [Feature/regressing bug #]: bug 1141041 [User impact if declined]: alternative styles from <style> elements have stopped working; broken test [Describe test coverage new/current, TreeHerder]: fixed the test in this patch, now actually has coverage [Risks and why]: low, minor change, increased test coverage [String/UUID change made/needed]: no.
Attachment #8750319 -
Flags: approval-mozilla-aurora?
Comment 9•8 years ago
|
||
Comment on attachment 8750319 [details] MozReview Request: Bug 1271049 - fix showing alternative styles from <style> elements and make the test actually test things, r?mconley Fix a regression, has a (better) test, taking it.
Attachment #8750319 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/4fd7d6aeb9b4
Comment 12•8 years ago
|
||
I've seen this issue on this bug in Nightly 49.0a1 (2016-05-07) ; (Build ID: 20160507030302) from Linux. This Bug is now verified as fixed on Latest Firefox Aurora 49.0a2 (2016-07-30) (Build ID: 20160730004003) and also Verified Latest Firefox Beta 48.0 (Build ID: 20160726073904) User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0 User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0 OS: Linux 4.4.0-31-generic ; Ubuntu 16.04 (64 Bit)
QA Whiteboard: [bugday-20160727]
Comment 13•8 years ago
|
||
I've successfully reproduced this bug in Nightly 49.0a1 (2016-05-07) ; (Build ID: 20160507030302) from Windows. Verified as fixed on Latest Firefox Aurora 49.0a2 (2016-07-31) (Build ID: 20160731004003) and Latest Firefox Beta 48.0b9 (Build ID: 20160718142219) [bugday-20160727]
You need to log in
before you can comment on or make changes to this bug.
Description
•