[e10s] New tab position on middle click

VERIFIED FIXED in Firefox 48

Status

()

P1
normal
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: ivailo.stoianov1, Assigned: emtwo)

Tracking

({regression, regressionwindow-wanted})

Trunk
Firefox 50
regression, regressionwindow-wanted
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(e10s+, firefox47 unaffected, firefox48+ verified, firefox49+ verified, firefox50 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160507004025

Steps to reproduce:

1. Open a new blank tab.
2. Middle click on a pinned site.


Actual results:

The tab was opened at the end of my tab list.


Expected results:

The tab should've been opened after the current blank tab.

Comment 1

3 years ago
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=385840329d91&tochange=26d6392b5403
Status: UNCONFIRMED → NEW
Has Regression Range: --- → no
Has STR: --- → yes
Component: Untriaged → New Tab Page
Ever confirmed: true
Keywords: regression, regressionwindow-wanted

Comment 2

3 years ago
[Tracking Requested - why for this release]:
status-firefox47: --- → unaffected
status-firefox48: --- → affected
status-firefox49: --- → affected
tracking-firefox48: --- → ?
tracking-firefox49: --- → ?

Comment 3

3 years ago
This is e10s specific problem.
status-firefox47: unaffected → ---
status-firefox48: affected → ---
tracking-e10s: --- → ?
tracking-firefox48: ? → ---
tracking-firefox49: ? → ---
Keywords: regressionwindow-wanted
Summary: New tab position on middle click → [e10s] New tab position on middle click
Version: 48 Branch → Trunk
Regression in 48, tracking.
status-firefox47: --- → unaffected
status-firefox48: --- → affected
tracking-firefox48: --- → +
tracking-firefox49: --- → +

Updated

3 years ago
Flags: needinfo?(twalker)
Middle clicking a tab closes that tab.

Ivailo, are you using an add-on that changes that behavior?
Flags: needinfo?(twalker) → needinfo?(ivailo.stoianov1)
(Reporter)

Comment 6

2 years ago
(In reply to Tracy Walker [:tracy] from comment #5)
> Middle clicking a tab closes that tab.
> 
> Ivailo, are you using an add-on that changes that behavior?

I meant a middle click on a pinned site in the New Tab page(https://support.mozilla.org/en-US/kb/about-tiles-new-tab). Can confirm it's a e10s problem. Once disabled the bug is gone as well.

Comment 7

2 years ago
str
Ah, yes.  I can reproduce that and confirm it is happening only in e10s mode.  A bit clear STR's as follows:

1) open New Tab page
2) Pin one of the available pages offered
3) Open a few pages in their own tabs
4) go back to the New Tab page of step 1.
5) Middle click the option you pinned in step 2

Actual results:

The tab was opened at the end of the tab list. (happens in e10s only)

Expected results:

The tab should've been opened after the current blank tab. (works as expected in non-e10s)
Flags: needinfo?(ivailo.stoianov1)

Updated

2 years ago
Keywords: regressionwindow-wanted

Updated

2 years ago
Flags: needinfo?(bbermes)
Does this only happen on Windows?
(In reply to Barbara Bermes [:barbara] from comment #8)
> Does this only happen on Windows?

It is reproducible on all platforms.
OS: Unspecified → All
Hardware: Unspecified → All
It's not blocking but should be something to be worked on soon, i.e P1, it's an expected behaviour that the user is currently not getting and might be frustrating for people who have a lot of tabs open.
Flags: needinfo?(bbermes)

Updated

2 years ago
tracking-e10s: ? → +
Priority: -- → P1
Tim, is there someone on the newtab team(?) who can look into this?
Flags: needinfo?(tspurway)
(Assignee)

Updated

2 years ago
Assignee: nobody → msamuel
:emtwo is taking a look at this
Flags: needinfo?(tspurway)
(Assignee)

Comment 13

2 years ago
Created attachment 8766598 [details] [diff] [review]
v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.
Attachment #8766598 - Flags: review?(oyiptong)
(Assignee)

Comment 14

2 years ago
Waiting on bug 1283332 to run this on try server, but tests pass locally.
(Assignee)

Comment 15

2 years ago
Comment on attachment 8766598 [details] [diff] [review]
v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c0170bee84b59d60aa176a87c5c4a713381b1b5

Mostly done on try and looking good.
Attachment #8766598 - Flags: review?(oyiptong) → review?(ursulasarracini)
Attachment #8766598 - Flags: review?(ursulasarracini) → review+
(Assignee)

Comment 16

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/e3d304afd3f2bb3301374a37486f48174a367c27
Bug 1271075: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'. r=ursulasarracini

Comment 17

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e3d304afd3f2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Hi Marina, do you want to uplift this for 48/49 if this patch is not too risky?
Flags: needinfo?(msamuel)
(Assignee)

Comment 19

2 years ago
Hi Gerry, I do believe this patch isn't too risky and it sounds like something that could be frustrating to users so I do support uplifting it.
Flags: needinfo?(msamuel)
(Assignee)

Comment 20

2 years ago
Comment on attachment 8766598 [details] [diff] [review]
v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.

Approval Request Comment

[Feature/regressing bug #]: Bug 1054221 

[User impact if declined]: Middle click on newtab links opens a tab at the end of the tab list but it should open right next to the newtab page. This may be a frustration to many users who use this functionality often.

[Describe test coverage new/current, TreeHerder]: New tests added. Existing tests pass on try, fx-team, and m-c

[Risks and why]: Not much risk. It's a 1-liner with passing tests.

[String/UUID change made/needed]: n/a
Attachment #8766598 - Flags: approval-mozilla-beta?
Attachment #8766598 - Flags: approval-mozilla-aurora?
Comment on attachment 8766598 [details] [diff] [review]
v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.

Has a new test, seems good to fix this e10s issue for early rollout in 48.
Attachment #8766598 - Flags: approval-mozilla-beta?
Attachment #8766598 - Flags: approval-mozilla-beta+
Attachment #8766598 - Flags: approval-mozilla-aurora?
Attachment #8766598 - Flags: approval-mozilla-aurora+
We should verify this fix once it lands on beta. 
If it causes any regressions, let's think about backing it out immediately, at least from beta.

Updated

2 years ago
Flags: qe-verify+

Comment 23

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/7c544c41ae8f
status-firefox49: affected → fixed
 https://hg.mozilla.org/releases/mozilla-beta/rev/d142c49033c0
status-firefox48: affected → fixed
I reproduced this bug using Fx 49.0a1 build ID:20160507030302 , on Windows 10 x64.
Confirmed the fix on Fx 48.0b6, build ID  20160706215822; Fx 49.0a2, build ID  20160707004018;  and Fx 50.0a1, build ID 20160701030235 on Windows 10 x64, Mac OS X 10.11.1 and Ubuntu 14.04 LTS.
Status: RESOLVED → VERIFIED
status-firefox48: fixed → verified
status-firefox49: fixed → verified
status-firefox50: fixed → verified
You need to log in before you can comment on or make changes to this bug.