1271091 - Uncloak the Geolocation preference UI for release builds once this feature is confirmed working

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[rsx11m]

This was thus far disabled on release builds by bug 994093 given that we didn't have an API key to enable this feature. Once this is confirmed working, this can be made visible on release builds as well.

(In reply to rsx11m from bug 903439 comment #13)
> This override got removed by bug 1172559 attachment 8630068 [details] [diff] [review]
> already, even though it appears that the ultimate fix was adding
> the geo.wifi.uri pref. What makes me worry is that I never saw the
> doorhanger notifications for sites requesting the location, which was the
> motivation in comment #2 for disabling geo.enabled in the first place.

I'm wondering if this implies any further action when disabling the feature, like clearing geo.wifi.uri to an empty string to avoid the "fallback" being used?

Comment 1

[rsx11m]

Attachment: Backout patch

This reverts the portions of bug 994093 attachment 8414447 [details] [diff] [review] which hide the geoLocationGroup radiogroup from the UI in release builds.

Help updates will be covered in bug 494424 once this is ready to land.

Comment 2

[rsx11m]

Comment on attachment 8750046 [details] [diff] [review]
Backout patch

Interesting - I found https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation and it works with both SeaMonkey 2.47a1 (my own Linux build) and even the 2.40 release (both Windows and Linux), which shows me almost the same location as Firefox 47.0 does. Thus, it seems to do something right, even though it may be improved by further fine-grained information after bug 903439 is done.

So, bottom line, I don't see the point of hiding the preferences UI any more, especially given that geo.enabled has been changed back to a default of true and users may be looking for a way to switch off location-aware browsing (e.g., getting annoyed by the doorhangers).

Please approve branches as you see fit (in fact, this patch doesn't change anything for the nightly builds, thus requesting branch approval with the review).

Comment 3

[Ian Neal]

Comment on attachment 8750046 [details] [diff] [review]
Backout patch

r/a=me for all repos

Comment 4

[rsx11m]

Thanks, pushed as approved.

https://hg.mozilla.org/comm-central/rev/85f52c5d52ca
https://hg.mozilla.org/releases/comm-aurora/rev/fd920df4bef8
https://hg.mozilla.org/releases/comm-beta/rev/d4bd6be465f5
https://hg.mozilla.org/releases/comm-release/rev/f1ea7e8e17a8