Closed Bug 1271104 Opened 8 years ago Closed 8 years ago

Intermittent testPrivateBrowsing | GeckoEventExpecter - blockForEvent timeout: Tab:Added

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 fixed, firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: aryx, Assigned: gbrown)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

use Tabs.loadUrl instead of robotium menu selection for tab creation
7.64 KB, patch
sebastian
: review+
Details | Diff | Splinter Review 
13:40:21     INFO -  TEST-START | testPrivateBrowsing
13:40:21     INFO -  TEST-PASS | testPrivateBrowsing | Robocop tests need the test device screen to be powered on. -
13:40:21     INFO -  TEST-PASS | testPrivateBrowsing | Given message occurred for registered event: {"type":"Gecko:Ready"} - Gecko:Ready should equal Gecko:Ready
13:40:21     INFO -  EventExpecter: no longer listening for Gecko:Ready
13:40:21     INFO -  TEST-PASS | testPrivateBrowsing | waiting for urlbar text to gain focus - urlbar text gained focus
13:40:21     INFO -  TEST-PASS | testPrivateBrowsing | URL typed properly - about:blank should equal about:blank
13:40:21     INFO -  TEST-PASS | testPrivateBrowsing | Given message occurred for registered event: {"errorType":"","bgColor":"transparent","type":"DOMContentLoaded","tabID":0} - DOMContentLoaded should equal DOMContentLoaded
13:40:21     INFO -  EventExpecter: no longer listening for DOMContentLoaded
13:40:21     INFO -  TEST-PASS | testPrivateBrowsing | Menu view is not null - org.mozilla.gecko.toolbar.ShapedButtonFrameLayout{41935b10 V.E...C. ........ 704,0-800,96 #7f08008e app:id/menu} should not equal null
13:40:21     INFO -  TEST-PASS | testPrivateBrowsing | Waiting for menu item ^New private tab$ - ^New private tab$ is present and enabled


13:40:21  WARNING -  TEST-UNEXPECTED-FAIL | testPrivateBrowsing | GeckoEventExpecter - blockForEvent timeout: Tab:Added
13:40:21     INFO -  0 ERROR Exception caught during test! - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testPrivateBrowsing | GeckoEventExpecter - blockForEvent timeout: Tab:Added
13:40:21     INFO -  	at junit.framework.Assert.fail(Assert.java:50)
13:40:21     INFO -  	at org.mozilla.gecko.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:128)
13:40:21     INFO -  	at org.mozilla.gecko.FennecMochitestAssert.ok(FennecMochitestAssert.java:150)
13:40:21     INFO -  	at org.mozilla.gecko.FennecNativeActions$GeckoEventExpecter.blockForEvent(FennecNativeActions.java:97)
13:40:21     INFO -  	at org.mozilla.gecko.FennecNativeActions$GeckoEventExpecter.blockForEvent(FennecNativeActions.java:81)
13:40:21     INFO -  	at org.mozilla.gecko.tests.PixelTest.addTab(PixelTest.java:63)
13:40:21     INFO -  	at org.mozilla.gecko.tests.testPrivateBrowsing.addTab(testPrivateBrowsing.java:19)
13:40:21     INFO -  	at org.mozilla.gecko.tests.testPrivateBrowsing.testPrivateBrowsing(testPrivateBrowsing.java:30
As before, robocop thinks it has clicked on "New private tab" but there is no indication that Fennec sees the click.
status-firefox50: --- → affected
status-firefox51: --- → affected
Assignee: nobody → gbrown
The main change here is to replace the apparently-unreliable robotium-based menu selection -- PixelTest.addTab() -- with calls to Tabs.loadUrl(). I had to add some sleep() calls to avoid other intermittents. I think the result is a reliable test:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=43d765c74c96
Attachment #8783559 - Flags: review?(snorp)
Comment on attachment 8783559 [details] [diff] [review]
use Tabs.loadUrl instead of robotium menu selection for tab creation

Review of attachment 8783559 [details] [diff] [review]:
-----------------------------------------------------------------

I think it makes more sense for Sebastian to review this
Attachment #8783559 - Flags: review?(snorp) → review?(s.kaspari)
Comment on attachment 8783559 [details] [diff] [review]
use Tabs.loadUrl instead of robotium menu selection for tab creation

Review of attachment 8783559 [details] [diff] [review]:
-----------------------------------------------------------------

You are kind of cheating here; but well, at this point everything that fixes intermittents is helpful. :)
Attachment #8783559 - Flags: review?(s.kaspari) → review+
Yeah, exactly. If we include the cloned bug, we're coming up on the 2 year anniversary of this bug...time to be aggressive, or give up on the test entirely.
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76ca3e09b1c9
Avoid menu selection in robocop testPrivateBrowsing; r=sebastian
https://hg.mozilla.org/mozilla-central/rev/76ca3e09b1c9
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: