Closed Bug 127113 Opened 23 years ago Closed 22 years ago

SidebarRebuild() is horked

Categories

(SeaMonkey :: Sidebar, defect, P3)

Product:
SeaMonkey
Component:
Sidebar
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: samir_bugzilla, Assigned: samir_bugzilla)

References

Details

(Keywords: regression, Whiteboard: [adt1] [ready to checkin])

Attachments

(1 file, 1 obsolete file)

Better patch that also addresses the case when panels are added or removed from the customize sidebar dialog.
1.41 KB, patch
morse
: review+
hewitt
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
In two cases the sidebar does not ``repaint'' the tabs:

(1) after returning from print preview 
(2) if the windows integration dialog pops up the first window won't have 
    sidebar tabs

Both call SidebarRebuild() which doesn't seem to be working anymore.
Nominating.
Keywords: nsbeta1
Priority: -- → P3
Target Milestone: --- → mozilla1.0
Samir, just curious if this has been broken for awhile if this attributes to the
mail/news sidebar painting/not loading problem after the account wizard dialog
is dismissed.  ie bug 123205.
No, this broke very recently I believe.
Keywords: regression
Sidebar becomes blank if I return from "Customize sidebar" dialog.
cc meself. Changing severity to major as this affects IM in a big way.
Severity: normal → major
nsbeta1+ per Nav triage team
Keywords: nsbeta1 → nsbeta1+
for those who need to use their sidebar tabs and come across this, unchecking
and re-checking each tab you need from the 'Tabs' pulldown seems to work.
*** Bug 127155 has been marked as a duplicate of this bug. ***
*** Bug 130625 has been marked as a duplicate of this bug. ***
Whiteboard: [adt1]
*** Bug 131339 has been marked as a duplicate of this bug. ***
*** Bug 131270 has been marked as a duplicate of this bug. ***

    
    

    
  
morse, please r.
dveditz, please sr. 

Thanks.
Status: NEW → ASSIGNED
Keywords: patch, 
          
            review

    
    

    
  
Comment on attachment 75222 [details] [diff] [review]
Reset initialized so panels are brought in view

r=morse

        Attachment #75222 -
        Flags: review+

    
    

    
  


  
morse, please r again.
dveditz, please sr.

        Attachment #75222 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 75294 [details] [diff] [review]
Better patch that also addresses the case when panels are added or removed from the customize sidebar dialog.

r=morse

        Attachment #75294 -
        Flags: review+

    
    

    
  
Comment on attachment 75294 [details] [diff] [review]
Better patch that also addresses the case when panels are added or removed from the customize sidebar dialog.

sr=hewitt

        Attachment #75294 -
        Flags: superreview+

    
  
Keywords: review
Whiteboard: [adt1] → [adt1] [ready to checkin]

    
    

    
  
Comment on attachment 75294 [details] [diff] [review]
Better patch that also addresses the case when panels are added or removed from the customize sidebar dialog.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

        Attachment #75294 -
        Flags: approval+

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
looks good on commercial trunk builds:

windows 2002-03-22-05-trunk
linux 2002-03-22-06-trunk
mac osx 2002-03-22-06-trunk
Status: RESOLVED → VERIFIED

    
  
Blocks: 128354

    
  
Blocks: 131044

    
    

    
  
*** Bug 133958 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: