Closed Bug 1271242 Opened 4 years ago Closed 4 years ago

[EME] Remove GMPDecryptorCallback::SetCapabilities()

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

Now that GMPParent detects whether gmp-clearkey can decode using AAC/H.264 using WMF before reporting gmp-clearkey can decode AAC/H.264, we don't need the GMPDecryptorCallback::SetCapabilities() callback from the GMP to signal the GMP can decode. We can now trust what the GMPService tells us.

So we can remove the "waiting for CDM caps" step in the state machine's startup sequence.

If we need more caps, like for an decode-and-render path, we can declare those as API strings in the info file.

I was also thinking we can rename the codec strings in the info file to have a "wmf-" prefix on Windows, to signal that we should check for WMF before reporting we can decode that.
Now that GMPParent detects whether gmp-clearkey can decode using AAC/H.264
using WMF before reporting gmp-clearkey's GMPParent can decode AAC/H.264, we
don't need the GMPDecryptorCallback::SetCapabilities() callback from the GMP to
signal to the PDMFactory that the GMP can decode. We can now trust what the
GMPService tells us.

So we can remove the "waiting for CDM caps" step in the state machine's startup
sequence. And all the plumbing. :)

If we need more caps, like for an decode-and-render path, we can declare those
as API strings in the info file.

Review commit: https://reviewboard.mozilla.org/r/51443/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51443/
Attachment #8750528 - Flags: review?(jwwang)
Attachment #8750528 - Flags: review?(jwwang) → review+
Comment on attachment 8750528 [details]
MozReview Request: Bug 1271242 - Remove GMPDecryptorCallback::SetCapabilities(). r?jwwang

https://reviewboard.mozilla.org/r/51443/#review48269

Comfortable!
https://hg.mozilla.org/mozilla-central/rev/bc8055a37b4a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1271883
You need to log in before you can comment on or make changes to this bug.