Add a test to ensure NotifyLayersUpdated copies all the right fields

RESOLVED WONTFIX

Status

()

P5
normal
RESOLVED WONTFIX
3 years ago
11 months ago

People

(Reporter: kats, Unassigned)

Tracking

49 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: gfx-noted)

In AsyncPanZoomController::NotifyLayersUpdated we do this thing where we copy a bunch of fields from one scroll metadata object to another. We should add some gtests to make sure that all the right things are getting copied in the different branches, so that if a new field is added we don't accidentally miss copying it.
Whiteboard: gfx-noted
Priority: -- → P5
status-firefox49: affected → ---
Version: Trunk → 49 Branch
Mentor: botond
I don't really understand what the intention is to do in this test. After triggering the code that's supposed to do the copying, the test would need to either check that each field was copied individually (in which case, the test doesn't serve much purpose since after adding a new field you could forget to add the check to the *test*), or it uses operator==, in which case you're relying on the user remembering to add the field to operator==.
Yeah.. I'd be ok closing this bug as invalid or wontfix.

Updated

11 months ago
Mentor: botond
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.