Closed
Bug 1271328
Opened 8 years ago
Closed 6 years ago
Add a test to ensure NotifyLayersUpdated copies all the right fields
Categories
(Core :: Panning and Zooming, defect, P5)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: kats, Unassigned)
Details
(Whiteboard: gfx-noted)
In AsyncPanZoomController::NotifyLayersUpdated we do this thing where we copy a bunch of fields from one scroll metadata object to another. We should add some gtests to make sure that all the right things are getting copied in the different branches, so that if a new field is added we don't accidentally miss copying it.
Updated•8 years ago
|
Whiteboard: gfx-noted
Reporter | ||
Updated•8 years ago
|
Priority: -- → P5
Reporter | ||
Updated•8 years ago
|
status-firefox49:
affected → ---
Version: Trunk → 49 Branch
Updated•8 years ago
|
Mentor: botond
Comment 1•6 years ago
|
||
I don't really understand what the intention is to do in this test. After triggering the code that's supposed to do the copying, the test would need to either check that each field was copied individually (in which case, the test doesn't serve much purpose since after adding a new field you could forget to add the check to the *test*), or it uses operator==, in which case you're relying on the user remembering to add the field to operator==.
Reporter | ||
Comment 2•6 years ago
|
||
Yeah.. I'd be ok closing this bug as invalid or wontfix.
Updated•6 years ago
|
Mentor: botond
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•