Closed Bug 1271338 Opened 5 years ago Closed 5 years ago

Port Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component to im and mail

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 49.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Bug 1223728 removed the unifiedcomplete.manifest, nsPlacesAutoComplete.manifest and nsPlacesAutoComplete.js which results in an error during make installer.
Attached patch Bug1271338.patchSplinter Review
Mail at least needs all three files to remove. Done the same for im.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8750348 - Flags: review?(aleth)
Jörg, in editor is still a autocompletesearch="history" (https://dxr.mozilla.org/comm-central/source/editor/ui/dialogs/content/EdDialogOverlay.xul#56 ). Is this used in composer and needs a change to autocompletesearch="unifiedcomplete"?
Flags: needinfo?(mozilla)
Hmm, to be honest, I've never seen this. You're referring to:
<vbox id="LinkLocationBox">
  <label control="hrefInput" accesskey="&LinkURLEditField.accessKey;" width="1">&LinkURLEditField.label;</label>
  <textbox id="hrefInput" type="autocomplete"
           autocompletesearch="history" timeout="50" maxrows="6"
Where is this in the TB UI? Or is this used by SM only?
Flags: needinfo?(mozilla)
In the dialog "Insert Link..." the Link Location textbox has the  id hrefInput. There is also the type="autocomplete".

And under Win10 this textbox looks a bit squashed...
Attachment #8750348 - Flags: review?(aleth) → review+
Yes, I was looking at the "Insert Link", as you said, it's hrefInput I didn't see the LinkLocationBox. Sorry. Yes, this has been squashed for as long as I can think.
Yes, now I see "autocomplete" and "history" in my DOM Inspector.

But sadly, I still don't know anything about it. Have you tried with "unifiedcomplete". Who says it needs to change? I vaguely remember bug 1256681. Anyway, Magnus is the autocomplete man ;-)
Flags: needinfo?(mkmelin+mozilla)
http://hg.mozilla.org/comm-central/rev/36410244f766
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
It should probably change to unifiedcomplete. (Don't have a new enough build handy to check atm.)
If that doesn't work, it doesn't really need to be an autocomplete field.
Depends on: 1272322
Bug https://hg.mozilla.org/comm-central/rev/cf9529c1f245 fixed the rest. Not sure why that didn't get linked here.
Flags: needinfo?(mkmelin+mozilla)
You need to log in before you can comment on or make changes to this bug.