Closed
Bug 1271348
Opened 8 years ago
Closed 8 years ago
Matrix print full width
Categories
(Core :: Printing: Output, defect)
Tracking
()
People
(Reporter: cristhian_sm, Assigned: bobowen)
References
Details
(Keywords: regression)
Attachments
(3 files, 1 obsolete file)
8.53 KB,
text/html
|
Details | |
1.94 MB,
image/jpeg
|
Details | |
58 bytes,
text/x-review-board-request
|
jimm
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 Build ID: 20160502172042 Steps to reproduce: I have this attached file, when sends to matrix printer like EPSON LX 300 Actual results: printing occupies 60 % of the page, in the previous version did not have that problem
Reporter | ||
Comment 1•8 years ago
|
||
I have returned to version 45.0.2 where I have no problems starting from version 46 problem exists
Assignee | ||
Comment 2•8 years ago
|
||
Thanks for reporting this. That html file seems to reference a load of other JavaScript, do you have an example that doesn't require this? Also, do you happen to have print.always_print_silent set to true in about:config?
Flags: needinfo?(cristhian_sm)
Reporter | ||
Comment 3•8 years ago
|
||
Whit this html file you can test the width problem printing on matrix printer like EPSON LX 300
Reporter | ||
Comment 4•8 years ago
|
||
Also the characters appears mounted only when sends to matrix printer like EPSON LX 300
Attachment #8750372 -
Attachment is obsolete: true
I tried with virtual printers, it's printed fine. Maybe related only to some physical printers. If it worked in F45, you can install Mozregression to find a regression range: http://mozilla.github.io/mozregression/ Run the command "mozregression --good=45" then copy here the final pushlog given in the console output.
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to csanmartin from comment #3) > Created attachment 8750409 [details] > ejemplo.html > > Whit this html file you can test the width problem printing on matrix > printer like EPSON LX 300 Thanks, I've downloaded that printer driver and found the problem. I'd moved the calculation of the size of the internal printing surface. Unfortunately I used the width pixels per logical inch in the calculation of the width, but because we only scale using the height pixels per logical inch, this is incorrect. On most printers I think they're the same, but on the EPSON LX 300 (and possibly other dot matrix printers), the width pixels is 120 and the height pixels is 72, giving the 60% problem.
Assignee: nobody → bobowen.code
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(cristhian_sm)
Assignee | ||
Comment 7•8 years ago
|
||
[Tracking Requested - why for this release]: Regression caused by changes in bug 1238964 - affects printing on Windows to printers with different horizontal and vertical pixels per inch.
status-firefox46:
--- → affected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox49:
--- → affected
tracking-firefox46:
--- → ?
tracking-firefox47:
--- → ?
tracking-firefox48:
--- → ?
Keywords: regression
OS: Unspecified → Windows
Hardware: Unspecified → All
Assignee | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51635/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51635/
Attachment #8750797 -
Flags: review?(jmathies)
Comment 9•8 years ago
|
||
Comment on attachment 8750797 [details] MozReview Request: Bug 1271348: Only use LOGPIXELSY for calculating internal printing surface size on Windows. r?jimm https://reviewboard.mozilla.org/r/51635/#review48447
Attachment #8750797 -
Flags: review?(jmathies) → review+
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df5b72f85c60
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Reporter | ||
Comment 12•8 years ago
|
||
Hi, Wich version i have to download to test the fix? the new version is ready to download?
Assignee | ||
Comment 13•8 years ago
|
||
(In reply to csanmartin from comment #12) > Hi, > > Wich version i have to download to test the fix? the new version is ready > to download? It has just landed, so it should be in tomorrow's Nightly, thanks.
Assignee | ||
Comment 14•8 years ago
|
||
By the way, just in case you're not aware of this, if you run it with: firefox -no-remote -P It will bring up the Profile dialog and you can create another profile for testing, if you don't want to use your normal one.
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8750797 [details] MozReview Request: Bug 1271348: Only use LOGPIXELSY for calculating internal printing surface size on Windows. r?jimm Nominating for release as well in case we have a dot release. Approval Request Comment [Feature/regressing bug #]: Regressed by bug 1238964. [User impact if declined]: Users will continue to have incorrectly sized pages if printing to printers that have different X to Y resolution. This includes at least some dot matrix printers. [Describe test coverage new/current, TreeHerder]: Tested manually using printer drivers for a dot matrix printer. Should have original reporter testing soon. [Risks and why]: Low - simple code change that reverts to previous calculation using just the Y resolution. [String/UUID change made/needed]: None.
Attachment #8750797 -
Flags: approval-mozilla-release?
Attachment #8750797 -
Flags: approval-mozilla-beta?
Attachment #8750797 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 16•8 years ago
|
||
Hi, have you been able to test this, it should be in the latest Nightly version: https://nightly.mozilla.org/
Flags: needinfo?(cristhian_sm)
Reporter | ||
Comment 17•8 years ago
|
||
Hi, I tried it with the Nigthly version indicated , and printing was ok. This will be available in the new version of firefox ? when?
Comment 18•8 years ago
|
||
For sure, in Firefox 47 in June.
Comment 19•8 years ago
|
||
Comment on attachment 8750797 [details] MozReview Request: Bug 1271348: Only use LOGPIXELSY for calculating internal printing surface size on Windows. r?jimm Fix for Windows printing regression in 46. Please uplift to aurora and beta.
Attachment #8750797 -
Flags: approval-mozilla-beta?
Attachment #8750797 -
Flags: approval-mozilla-beta+
Attachment #8750797 -
Flags: approval-mozilla-aurora?
Attachment #8750797 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 20•8 years ago
|
||
Thanks Cristhian, for testing and reporting in the first place.
Flags: needinfo?(cristhian_sm)
Comment 21•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/01daa1cb8a99
Comment 22•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/6ff99c310051
Comment 23•8 years ago
|
||
Too late for 46, but the fix will be coming in early to mid june.
tracking-firefox49:
--- → +
Comment on attachment 8750797 [details] MozReview Request: Bug 1271348: Only use LOGPIXELSY for calculating internal printing surface size on Windows. r?jimm Clearing the m-r flag as 46 will EOL in a week and this fix is already in Beta47.
Attachment #8750797 -
Flags: approval-mozilla-release?
You need to log in
before you can comment on or make changes to this bug.
Description
•