Closed Bug 1271356 Opened 8 years ago Closed 8 years ago

Skia update to m51 branch caused regression in num_constructors and android apk size

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Skia has been growing steadily so it is unsurprising that various build metrics are growing... In an effort to put Skia on a diet, I've cut out a lot of utils and effects code we never actually use. In the process of this, I had to remove some global initializers that were otherwise keeping the code alive.

I tried cutting out other bits of Skia, like the test code or the linear pipeline, but they're too entangled and poorly isolated that it would have required too extensive modifications to do so.
Attachment #8750406 - Flags: review?(jmuizelaar)
Whiteboard: [gfx-noted]
Attachment #8750406 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/db601218b337
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: