1271380 - Report search counts in core ping

Status: RESOLVED FIXED

(Firefox for iOS :: Telemetry, defect)

Description

[Brian Nicholson (:bnicholson)]

Draft: https://docs.google.com/document/d/1z3kD4EBO5_xFke2NTar2GvlCIkJaTHxwz3IjRGpWC2U

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1843

When creating the core ping, we immediately reset the search data that we're reporting. That means if we create the ping but the ping isn't successful, we'll drop the data. That's why the network connectivity check was added to the PR: it increases the likelihood that the ping will succeed.

Unless we want to take the time to implement a telemetry fault-handling layer that stores and resends unique pings, I think this is the best we can do. The other option would be to reset the count only after receiving an HTTP 200, where we'd instead be sending potentially duplicate pings instead of dropping them. I agree with mcomella's comment [1] that missing data is better than bad data.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1271378#c4

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8755217 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1843

Seems reasonable to me with my comments taken into account.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8755217 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1843

Looks good. I like the two new classes to organize this functionality.

Comment 4

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/12e9005d365b862e7eedafd1a18a73e727e75f99