1271389 - Compiler error in nsStyleStruct.h with VC 2013 - blocking development

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3662) : error C2275: 'nsPoint' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsPoint.h(22) : see declaration of 'nsPoint'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3662) : error C2275: 'nsPoint_Simple' : illegal use of thistype as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3658) : see declaration of 'nsPoint_Simple'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3662) : error C3861: 'alignof': identifier not found
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3673) : error C2275: 'nsMargin' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsMargin.h(14) : see declaration of 'nsMargin'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3673) : error C2275: 'nsMargin_Simple' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3669) : see declaration of 'nsMargin_Simple'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3673) : error C3861: 'alignof': identifier not found
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3686) : error C2275: 'nsRect' : illegal use of this type asan expression
 0:32.46         c:\Users\msreckovic\Repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsRect.h(24) : see declaration of 'nsRect'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3686) : error C2275: 'nsRect_Simple' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3682) : see declaration of 'nsRect_Simple'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3686) : error C3861: 'alignof': identifier not found
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3705) : error C2275: 'nsTArray<T>' : illegal use of this type as an expression
 0:32.46         with
 0:32.46         [
 0:32.46             T=nsStyleImageLayers::Layer
 0:32.46         ]
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3705) : error C2275: 'nsTArray_Simple<nsStyleImageLayers::Layer>' : illegal use of this type as an expression

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

I don't know when this started, so I'm going to spam with needinfo a few last people that touched that file.

Comment 2

[Markus Stange [:mstange]]

nsStyleImageLayers::Layer sounds like it was my fault. Are we missing an include?

Comment 3

[Markus Stange [:mstange]]

Milan, can you attach c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h to this bug so that we can see what the error messages are referring to?

Comment 4

[Bobby Holley (:bholley)]

See bug 1270305#c9 and onward.

Comment 5

[Bobby Holley (:bholley)]

Are we supporting VS2013? If so, why isn't it running on tinderbox?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

(In reply to Bobby Holley (busy) from comment #5)
> Are we supporting VS2013? If so, why isn't it running on tinderbox?

We have not yet dropped support for VS2013, but it's not necessarily tier 1 anymore.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: nsStyleStruct.h

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Markus Stange [:mstange] from comment #3)
> Milan, can you attach
> c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-
> mingw32\dist\include\nsStyleStruct.h to this bug so that we can see what the
> error messages are referring to?

Done.

Comment 9

[Markus Stange [:mstange]]

Thanks, sounds like we don't need it any more since we know what the problem is (bug 1270305 comment 10).

Comment 10

[Botond Ballo [:botond]]

I posted a workaround patch in bug 1270305.

Comment 11

[Milan Sreckovic [:milan] (needinfo for best results)]

That one works, thanks, now the Thread thing is the blocker.

Comment 12

[Daniel Holbert [:dholbert]]

7 years have passed, presumably this compiler error is a non-issue at this point. Feel free to reopen if anyone is still hitting this, though!