Compiler error in nsStyleStruct.h with VC 2013 - blocking development

NEW
Unassigned

Status

()

Core
Layout
2 years ago
2 years ago

People

(Reporter: milan, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3662) : error C2275: 'nsPoint' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsPoint.h(22) : see declaration of 'nsPoint'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3662) : error C2275: 'nsPoint_Simple' : illegal use of thistype as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3658) : see declaration of 'nsPoint_Simple'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3662) : error C3861: 'alignof': identifier not found
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3673) : error C2275: 'nsMargin' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsMargin.h(14) : see declaration of 'nsMargin'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3673) : error C2275: 'nsMargin_Simple' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3669) : see declaration of 'nsMargin_Simple'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3673) : error C3861: 'alignof': identifier not found
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3686) : error C2275: 'nsRect' : illegal use of this type asan expression
 0:32.46         c:\Users\msreckovic\Repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsRect.h(24) : see declaration of 'nsRect'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3686) : error C2275: 'nsRect_Simple' : illegal use of this type as an expression
 0:32.46         c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3682) : see declaration of 'nsRect_Simple'
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3686) : error C3861: 'alignof': identifier not found
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3705) : error C2275: 'nsTArray<T>' : illegal use of this type as an expression
 0:32.46         with
 0:32.46         [
 0:32.46             T=nsStyleImageLayers::Layer
 0:32.46         ]
 0:32.46 c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h(3705) : error C2275: 'nsTArray_Simple<nsStyleImageLayers::Layer>' : illegal use of this type as an expression
I don't know when this started, so I'm going to spam with needinfo a few last people that touched that file.
Flags: needinfo?(tlin)
Flags: needinfo?(mstange)
Flags: needinfo?(ecoal95)
Flags: needinfo?(bobbyholley)
nsStyleImageLayers::Layer sounds like it was my fault. Are we missing an include?
Flags: needinfo?(mstange)
Milan, can you attach c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-mingw32\dist\include\nsStyleStruct.h to this bug so that we can see what the error messages are referring to?
See bug 1270305#c9 and onward.
Flags: needinfo?(ecoal95)
Flags: needinfo?(bobbyholley)
Are we supporting VS2013? If so, why isn't it running on tinderbox?
(In reply to Bobby Holley (busy) from comment #5)
> Are we supporting VS2013? If so, why isn't it running on tinderbox?

We have not yet dropped support for VS2013, but it's not necessarily tier 1 anymore.
(In reply to Markus Stange [:mstange] from comment #3)
> Milan, can you attach
> c:\users\msreckovic\repos\mozilla-central\obj-i686-pc-
> mingw32\dist\include\nsStyleStruct.h to this bug so that we can see what the
> error messages are referring to?

Done.
Flags: needinfo?(mstange)
Thanks, sounds like we don't need it any more since we know what the problem is (bug 1270305 comment 10).
Flags: needinfo?(tlin)
Flags: needinfo?(mstange)
I posted a workaround patch in bug 1270305.
That one works, thanks, now the Thread thing is the blocker.
You need to log in before you can comment on or make changes to this bug.