Closed
Bug 1271502
Opened 8 years ago
Closed 8 years ago
list does not align well in private browsing new tab page with locale lang
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | fixed |
firefox49 | --- | fixed |
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
(Keywords: regression)
Attachments
(2 files)
187.88 KB,
image/png
|
Details | |
58 bytes,
text/x-review-board-request
|
Gijs
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
No description provided.
Assignee | ||
Updated•8 years ago
|
Summary: list does not in private browsing new tab page → list does not align well in private browsing new tab page with locale lang
Assignee | ||
Comment 1•8 years ago
|
||
Tested with Developer Edition (48) on mac and linux, The reason is the font height does not the same in English (height: 20px) and Chinese(height: 24px) at first row. It makes the overflow rule render an unexpected layout.
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51483/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51483/
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gasolin
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8750576 [details] MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; r?Gijs Ricky, could you help take a look for layout in different locale?
Attachment #8750576 -
Flags: feedback?(rchien)
Comment 5•8 years ago
|
||
https://reviewboard.mozilla.org/r/51483/#review48653 Thank you Fred! It works on my developer edition. However, I'm wondering why it doesn't happen when trying to replace english word to chinese in en-US developer edition? ::: browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css:69 (Diff revision 1) > p { > line-height: 1.5em; > } > > .list-row { > - overflow: auto; > + overflow: hidden; What is this used for? I didn't see anything different after applying this line.
Updated•8 years ago
|
Attachment #8750576 -
Flags: feedback?(rchien) → feedback+
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Ricky Chien [:rickychien] from comment #5) > https://reviewboard.mozilla.org/r/51483/#review48653 > > Thank you Fred! It works on my developer edition. However, I'm wondering why > it doesn't happen when trying to replace english word to chinese in en-US > developer edition? > > ::: browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css:69 > (Diff revision 1) > > p { > > line-height: 1.5em; > > } > > > > .list-row { > > - overflow: auto; > > + overflow: hidden; > > What is this used for? > I didn't see anything different after applying this line. When I set the height for li item, I got unexpected scrollbar at right of the list-row. I think scrollbar is unnecessary for a list row.
Assignee | ||
Updated•8 years ago
|
Attachment #8750576 -
Flags: review?(gijskruitbosch+bugs)
Comment 7•8 years ago
|
||
Comment on attachment 8750576 [details] MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; r?Gijs This is going to break if the text in the <li>s ever wraps, which it might in other locales / different window sizes, because their width is limited. We should set line-height instead. Likewise, I don't think the change to overflow: auto is necessary - it seems likely to lead to clipping instead.
Attachment #8750576 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8750576 [details] MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; r?Gijs Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51483/diff/1-2/
Attachment #8750576 -
Attachment description: MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; → MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; r?Gijs
Attachment #8750576 -
Flags: feedback+ → review?(gijskruitbosch+bugs)
Updated•8 years ago
|
Attachment #8750576 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 9•8 years ago
|
||
Comment on attachment 8750576 [details] MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; r?Gijs https://reviewboard.mozilla.org/r/51483/#review48705
Assignee | ||
Comment 10•8 years ago
|
||
Thanks for review. I've change height to line-height and it works well. Also turn `margin-left` in list-row item to `-moz-margin-start`
Keywords: checkin-needed
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8750576 [details] MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; r?Gijs Approval Request Comment [Feature/regressing bug #]: bug 1259340 [User impact if declined]: the list in private browsing new tab page not shown correctly in locale language (test in chinese) [Describe test coverage new/current, TreeHerder]: N [Risks and why]: CSS only fix [String/UUID change made/needed]: N
Attachment #8750576 -
Flags: approval-mozilla-aurora?
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d450d458432d
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d450d458432d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 14•8 years ago
|
||
Minor layout regression from 48.
Comment 15•8 years ago
|
||
Comment on attachment 8750576 [details] MozReview Request: Bug 1271502 - list does not align well in private browsing new tab page with locale lang; r?Gijs CSS fix for new tab layout regression in 48. Please uplift to aurora.
Attachment #8750576 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 16•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/3229f5a133e3
You need to log in
before you can comment on or make changes to this bug.
Description
•