Closed Bug 1271514 Opened 8 years ago Closed 8 years ago

Shutdown threads we start in test_unlock_notify

Categories

(Toolkit :: Storage, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

test_unlock_notify doesn't shut down the threads it starts, which blocks landing thread-shutdown asserts
braces on lock needed to avoid deadlocking on the monitor
Attachment #8750582 - Flags: review?(nfroyd)
Comment on attachment 8750582 [details] [diff] [review]
clean up threads in test_unlock_notify

Review of attachment 8750582 [details] [diff] [review]:
-----------------------------------------------------------------

WFM.  I think making an explicit call is better than putting the call in ~DatabaseLocker so as to hopefully avoid footguns with the monitor and deadlock.

You may want to edit the bug summary before you land; I was a little confused.
Attachment #8750582 - Flags: review?(nfroyd) → review+
Summary: sdp_unittests doesn't Shutdown() the pseudo-main thread before finishing → Shutdown threads we start in test_unlock_notify
https://hg.mozilla.org/mozilla-central/rev/12d24425122e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: