1271525 - Crash in igdumd64.dll@0xd0ef0

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-f2482649-1e35-4a37-8ceb-fb2802160509.
=============================================================

18 occurrences of this crash across all versions since May 1st:

https://crash-stats.mozilla.com/signature/?product=Firefox&platform=Windows&date=%3E%3D2016-05-01&signature=igdumd64.dll%400xd0ef0&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&page=1#reports

igdumd64.dll appears to be an Intel HD graphics driver.

Comment 1

[Nicholas Nethercote [inactive]]

Milan, another graphics driver crash for your delectation.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

At a frequency of two crashes per day, it will take a while before we get to this.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Chris - is this related to any of the other recent black listings?

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #3)
> Chris - is this related to any of the other recent black listings?

No. The crash reports here are using D3D9 DXVA, whereas the recent black listings are for D3D11 DXVA.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Driver correlations:
1 	8.15.10.2189 	120 	85.71 %
2 	8.771.1.0 	1 	0.71 %

Device correlations:
1 	0x0046 	123 	87.86 %
2 	0x2e12 	5 	3.57 %
3 	0x2e22 	3 	2.14 %
4 	0x68e0 	1 	0.71 %

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: MozReview Request: Bug 1271525 - Factor out data used by FindD3D11BlacklistedDLL() into arguments passed in. r?kentuckyfriedtakahe

This enables us to use the existing D3D11 blacklist code to create a D3D9
blacklist by just passing in a new blacklist cache.

Review commit: https://reviewboard.mozilla.org/r/56512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56512/

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: MozReview Request: Bug 1271525 - Add ability to blacklist D3D9 DXVA via pref. r?kentuckyfriedtakahe

Review commit: https://reviewboard.mozilla.org/r/56514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56514/

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: MozReview Request: Bug 1271525 - Blacklist igdumd64.dll versions for D3D9 DXVA which are suspected to crash. r?kentuckyfriedtakahe

Review commit: https://reviewboard.mozilla.org/r/56516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56516/

Comment 9

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8758157 [details]
MozReview Request: Bug 1271525 - Blacklist igdumd64.dll versions for D3D9 DXVA which are suspected to crash. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/56516/#review53400

Comment 10

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8758155 [details]
MozReview Request: Bug 1271525 - Factor out data used by FindD3D11BlacklistedDLL() into arguments passed in. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/56512/#review53402

Comment 11

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8758156 [details]
MozReview Request: Bug 1271525 - Add ability to blacklist D3D9 DXVA via pref. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/56514/#review53404

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff84c527dd9c
Factor out data used by FindD3D11BlacklistedDLL() into arguments passed in. r=kentuckyfriedtakahe
https://hg.mozilla.org/integration/mozilla-inbound/rev/00cc1b05a611
Add ability to blacklist D3D9 DXVA via pref. r=kentuckyfriedtakahe
https://hg.mozilla.org/integration/mozilla-inbound/rev/596b037c156d
Blacklist igdumd64.dll versions for D3D9 DXVA which are suspected to crash. r=kentuckyfriedtakahe

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff84c527dd9c
https://hg.mozilla.org/mozilla-central/rev/00cc1b05a611
https://hg.mozilla.org/mozilla-central/rev/596b037c156d

Comment 14

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8758155 [details]
MozReview Request: Bug 1271525 - Factor out data used by FindD3D11BlacklistedDLL() into arguments passed in. r?kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]: Hardware accelerated video decoding
[User impact if declined]: Some crashes with hardware accelerated video decoding.
[Describe test coverage new/current, TreeHerder]: We have lots of video tests.
[Risks and why]: This will blacklist some peoples' drivers, so they'll fallback to software decoding. So they may experience reduced video playback performance. They will however, crash less!
[String/UUID change made/needed]: None.

Comment 15

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8758156 [details]
MozReview Request: Bug 1271525 - Add ability to blacklist D3D9 DXVA via pref. r?kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]: Hardware accelerated video decoding
[User impact if declined]: Some crashes with hardware accelerated video decoding.
[Describe test coverage new/current, TreeHerder]: We have lots of video tests.
[Risks and why]: This will blacklist some peoples' drivers, so they'll fallback to software decoding. So they may experience reduced video playback performance. They will however, crash less!
[String/UUID change made/needed]: None.

Comment 16

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8758157 [details]
MozReview Request: Bug 1271525 - Blacklist igdumd64.dll versions for D3D9 DXVA which are suspected to crash. r?kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]: Hardware accelerated video decoding
[User impact if declined]: Some crashes with hardware accelerated video decoding.
[Describe test coverage new/current, TreeHerder]: We have lots of video tests.
[Risks and why]: This will blacklist some peoples' drivers, so they'll fallback to software decoding. So they may experience reduced video playback performance. They will however, crash less!
[String/UUID change made/needed]: None.

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8758155 [details]
MozReview Request: Bug 1271525 - Factor out data used by FindD3D11BlacklistedDLL() into arguments passed in. r?kentuckyfriedtakahe

Less crashes, taking it

Comment 18

[Carsten Book [:Tomcat]]

has problems to apply to aurora:

grafting 347789:ff84c527dd9c "Bug 1271525 - Factor out data used by FindD3D11BlacklistedDLL() into arguments passed in. r=kentuckyfriedtakahe"
merging dom/media/platforms/wmf/WMFVideoMFTManager.cpp
warning: conflicts while merging dom/media/platforms/wmf/WMFVideoMFTManager.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 19

[Chris Pearce [:cpearce (Not reading bugmail)]]

The merge conflict was caused by the uplift of Bug 1273691, which had merge conflicts caused by jya's MediaPref change, and that ended up not renaming IsD3D11DLLBlacklisted() to FindD3D11BlacklistedDLL(), and hence the conflict here.

m-c changeset:
https://hg.mozilla.org/mozilla-central/rev/204bdc8b929c#l1.81

m-a changeset with bad merge:
https://hg.mozilla.org/releases/mozilla-aurora/rev/fc50dd4bc0f9#l1.54

I'll un-bitrot.

Comment 20

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 1 - (Beta rebase) Factor out data used by FindD3D11BlacklistedDLL() into arguments passed in

This enables us to use the existing D3D11 blacklist code to create a D3D9
blacklist by just passing in a new blacklist cache.


MozReview-Commit-ID: GyQ8o8U1jwg

Comment 21

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 2 - (Beta rebase) Add ability to blacklist D3D9 DXVA via pref

MozReview-Commit-ID: HSm6TTc6kct

Comment 22

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 3 - (Beta rebase) Blacklist igdumd64.dll versions for D3D9 DXVA which are suspected to crash

MozReview-Commit-ID: B4RET7bldTT

Comment 23

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/832476e829bb
https://hg.mozilla.org/releases/mozilla-beta/rev/ecaf4f7ac2a1
https://hg.mozilla.org/releases/mozilla-beta/rev/5bc65a29a8a7