Closed Bug 1271526 Opened 8 years ago Closed 8 years ago

Drop CommonAnimationManager::ExtractComputedValueForTransition

Categories

(Core :: DOM: Animation, defect)

Product:
Core
Component:
DOM: Animation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1223658
Tracking Flags:
Tracking Status
firefox49 --- affected

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file)

Drop CommonAnimationManager::ExtractComputedValueForTransition
6.64 KB, patch
hiro
: review+
Details | Diff | Splinter Review 
As of bug 1259285 this method is now pretty much empty. (We should have just removed it then.)
Summary: Drop AnimationCommon::ExtractComputedValueForTransition → Drop CommonAnimationManager::ExtractComputedValueForTransition
MozReview-Commit-ID: 2tQ5jjEkyxV
Attachment #8750606 - Flags: review?(hiikezoe)
Comment on attachment 8750606 [details] [diff] [review]
Drop CommonAnimationManager::ExtractComputedValueForTransition

Review of attachment 8750606 [details] [diff] [review]:
-----------------------------------------------------------------

This is exactly what I have been done in part 1 for bug 1223658 in my patch queue locally.

You could also drop including StyleAnimationValue.h and nsCSSProperty.h from AnimationCommon.h.
Attachment #8750606 - Flags: review?(hiikezoe) → review+
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> This is exactly what I have been done in part 1 for bug 1223658 in my patch
> queue locally.
> 
> You could also drop including StyleAnimationValue.h and nsCSSProperty.h from
> AnimationCommon.h.

Oh, you should just land that then!
OK, once tree is open, I will land the patch soon. Leaving ni? to me here just in case.
Flags: needinfo?(hiikezoe)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: