127156 - Show currently selected packs in language / content pack pref panel

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Robert Kaiser]

From bug 126714:

------- Additional Comment #11 From [e-mail] 2002-02-21 10:14 -------

I was going to log a separate bug for showing currently selected packs as that
is a new "feature".

Comment 1

[Robert Kaiser]

This should really get fixed before 1.0 (with a simple check icon) because it's
currently really hard to see what is currently installed. The "old" dropdown box
in Appearance panel had a notification like that.

Comment 2

[tao]

low impact; correctness ->[adt3]

seems to be fixed on 2002-05-10-1.0.0 ns build. need to verify.

Comment 3

[Robert Kaiser]

Tao, the currently shown as "selected" entry in the listboxes don't nesessarily
correspond to the actual applied language pack.

Additionally, I think the selection of the entry is too little to be recognized
as such. I think there such be something as a radio-button style icon, or a
checkmark, for the currently applied pack.

Comment 4

[tao]

ok. I agree that the UI needs improvement and this goes to theme as well.

Comment 5

[dbragg]

After much testing and tracing I've determined that this IS working correctly. 
The selected language pack and content pack are highlighted.  Granted there is
no check mark or radio button but that's a much more involved feature as there
is currently no widget like this available for a list box.

There is a quirk though.  A "default" content pack does not show up as selected
because the pref is not in the all.js file.  However, if you select the pack the
next time you start up it will show selected.  This is because the current code
uses the pref value general.useragent.contentlocale to get the currently
selected content pack.  This pref is not in the all.js file.  The strange thing
is that when the pref is added to the all.js file you can't select a content
pack into your profile's prefs.js.  I'm checking with the prefs meister on this
part.

Comment 6

[dbragg]

Attachment: changes to netscape.properties and all.js

Turns out the whole problem was that the default pref and value were not in
navigator.properties where the language pack one is.  I added the
general.useragent.contentlocale pref to navigator.properties and added the url
to navigator.properties to all.js.

Comment 7

[tao]

Comment on attachment 86463 [details] [diff] [review]
changes to netscape.properties and all.js

r=tao

Comment 8

[Michele Carlson]

l10n approved.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 86463 [details] [diff] [review]
changes to netscape.properties and all.js

sr=dveditz

Comment 10

[dbragg]

Looking for adt approval for branch and trunk check-in.  Adding adt1.0.1 keyword.

Comment 11

[Jaime Rodriguez, Jr.]

Moving adt1.0.1 keyword from Status Whiteboard to Keywords, so it gets on the
ADT radar. ;-)

jimmyu - can you verify this as fixed, once it has landed on the trunk. thanks!

Comment 12

[tao]

new owner ->tao

Comment 13

[scottputterman]

adding adt1.0.1- per ADt.

Comment 14

[[e-mail] (away - not reading bugmail)]

-> jbetak, I will put this in to the trunk later today. I will also investigate
some additional visual cue for the listbox.

Comment 15

[[e-mail] (away - not reading bugmail)]

requesting a= for Mozilla 1.1 trunk checkin

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 86463 [details] [diff] [review]
changes to netscape.properties and all.js

a=asa (on behalf of drivers) for checkin to 1.1

Comment 17

[[e-mail] (away - not reading bugmail)]

checked in - this should make it into Moz 1.1 and next Netscape release.

Marking fixed.

Comment 18

[Robert Kaiser]

man, how could we all look over this?

Sorry, I have to reopen this bug.

general.useragent.contentlocale shouldn't be in navigator.properties, it should
be somewhere in the content pack, not the language pack.

What we have in tree now would tell users they've selected a different content
pack after changing thier language pack!

Comment 19

[[e-mail] (away - not reading bugmail)]

Kairo, you're obviously correct. I've overlooked the packaging issue as well 
when I landed dbragg's patch.

I believe we should stick it into region.properties instead of 
navigator.properties. We need to get this into the Moz 1.1 release, patch 
coming up.

Comment 20

[[e-mail] (away - not reading bugmail)]

Attachment: corrected patch

this places contentlocale pref in region.properties, which should be part of
the content pack.

Kairo, could you review this?

Comment 21

[Robert Kaiser]

Comment on attachment 93618 [details] [diff] [review]
corrected patch

yes, this looks as it should be.
r=[e-mail]

Comment 22

[[e-mail] (away - not reading bugmail)]

thanks for catching this Kairo and for the review!

Dan, could you put another sr=dveditz on this? 
Sorry for missing the packaging issue :-(

Comment 23

[[e-mail] (away - not reading bugmail)]

checked in.

Kairo, could you please verify?

Comment 24

[Robert Kaiser]

looks correct now. verified.