1271609 - ReleaseAllJITCode should call Zone::discardJitCode instead of duplicating it

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

I'm working on a patch for this code, let's deduplicate it first.

 1 files changed, 2 insertions(+), 28 deletions(-)

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 8750750 [details] [diff] [review]
Patch

Review of attachment 8750750 [details] [diff] [review]:
-----------------------------------------------------------------

Good idea.

::: js/src/jsgc.cpp
@@ +7141,5 @@
>      fop->runtime()->gc.evictNursery();
>  
>      for (ZonesIter zone(fop->runtime(), SkipAtoms); !zone.done(); zone.next()) {
> +        zone->setPreservingCode(false);
> +        zone->discardJitCode(fop);

Zone::discardJitCode also calls JSScript::resetWarmUpCounter, so this will now happen when JIT code is discarded outside of a GC.  Do you think that will be a problem?

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Jon Coppeard (:jonco) from comment #1)
> Zone::discardJitCode also calls JSScript::resetWarmUpCounter, so this will
> now happen when JIT code is discarded outside of a GC.  Do you think that
> will be a problem?

Hm I missed that somehow, thanks.

resetWarmUpCounter is actually what we want here - after we throw out all JIT code we should go through the normal interpreter -> Baseline -> Ion warmup cycle. Baseline collects information Ion depends on, so jumping straight into Ion doesn't work well.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e4369105765

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e4369105765