1271674 - Xcode 7.3.1 Swift compiler crash on optimized build

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The Swift compiler in 7.3.1 crashes when compiling any of the Schemes that use the optimized build setting.

https://bugs.swift.org/browse/SR-1455

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

"Optimizer team's taking a look. Worst case, you can try disabling optimization per-func with @_semantics("optimize.sil.never") attr"

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1802

This patch changes the Swift Optimization Level from `-O -whole-module-optimization` to just `-O` for the *Storage* framework.

This is a temporary solution until we have a better idea how to deal with https://bugs.swift.org/browse/SR-1455 or until Apple provides an Xcode update that fixes this issue.

This fix now at least means we can continue to do builds. And the change is limited to *Storage*. The rest of the app compiles without issues with the original optimization settings.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8751344 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1802

LGTM