Closed Bug 1271701 Opened 4 years ago Closed 4 years ago

about:cache can cause shutdown hang

Categories

(Core :: Networking: Cache, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: mcmanus, Assigned: mayhemer)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Assignee: nobody → honzab.moz
Whiteboard: [necko-active]
...because we can use the code introduced there.
Status: NEW → ASSIGNED
Depends on: 1266196
Attached patch v1Splinter Review
Attachment #8751825 - Flags: review?(michal.novotny)
Attachment #8751825 - Flags: review?(michal.novotny) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ff923a89d88e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8751825 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: HTTP cache v2 + bug 1262009
[User impact if declined]: shutdown hang/crash when closing Fx and about:cache is still loading
[Describe test coverage new/current, TreeHerder]: few weeks on m-c, fixes one cause of the shutdown hang (there is tho one more bug to uplift as well, will ask a right after this one)
[Risks and why]: very low, this is only a diagnostic code, the patch only properly cancel internal loop involving a lot of IO when the channel (the page) is closed, which also happens during shutdown
[String/UUID change made/needed]: none
Attachment #8751825 - Flags: approval-mozilla-aurora?
Blocks: 1275898
Comment on attachment 8751825 [details] [diff] [review]
v1

Diagnostic code, taking it
Attachment #8751825 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.