1271701 - about:cache can cause shutdown hang

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Patrick McManus [:mcmanus]]

https://crash-stats.mozilla.com/signature/?signature=shutdownhang+%7C+WaitForSingleObjectEx+%7C+WaitForSingleObject+%7C+PR_WaitCondVar+%7C+PR_JoinThread+%7C+mozilla%3A%3Anet%3A%3ACacheIOThread%3A%3AShutdown

#2 shutdown hang crasher

Comment 1

[Honza Bambas (:mayhemer)]

...because we can use the code introduced there.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 3

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29c547985818328b9b7692ef10ae85f7097063c6

Comment 4

[Honza Bambas (:mayhemer)]

Better try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5a6263bbdfd

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff923a89d88e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff923a89d88e

Comment 7

[Honza Bambas (:mayhemer)]

Comment on attachment 8751825 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: HTTP cache v2 + bug 1262009
[User impact if declined]: shutdown hang/crash when closing Fx and about:cache is still loading
[Describe test coverage new/current, TreeHerder]: few weeks on m-c, fixes one cause of the shutdown hang (there is tho one more bug to uplift as well, will ask a right after this one)
[Risks and why]: very low, this is only a diagnostic code, the patch only properly cancel internal loop involving a lot of IO when the channel (the page) is closed, which also happens during shutdown
[String/UUID change made/needed]: none

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8751825 [details] [diff] [review]
v1

Diagnostic code, taking it

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c629b5f1d41e