1271706 - Warn when eslint is outdated

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Alexandre Poirot [:ochameau]]

It is quite easy to have an outdated eslint and leads to weird issues.
It would be great if mach was telling us more about that.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

I also replaced WindowsError by OSError as it throws on linux.
I'm not a python expect, but I imagine we do not have to be specific about WindowsError?

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8750863 [details] [diff] [review]
patch v1

Review of attachment 8750863 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=272b9cf93520

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bug 1270851 does this and more and only needs review... just saying.

Comment 5

[Alexandre Poirot [:ochameau]]

Not exactly that. It checks that the version within npm, but not the final binary you are running.
Which was the main issue I had locally.
npm was up-to-date, but another version was old and took the lead in my PATH.

Comment 6

[Alexandre Poirot [:ochameau]]

Would you mind rebasing on top of this?
I imagine both our patches are valuable.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Sure, I can do that and make use of your version reporting.

Comment 8

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/5cc872323d179d22abc2ff1ecbb4229160340e2d
Bug 1271706 - Warn when eslint is outdated. r=gps

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5cc872323d17