Closed Bug 1271713 Opened 8 years ago Closed 8 years ago

Port Bug 1271458 and Bug 967970 to Thunderbird

Categories

(Thunderbird :: OS Integration, defect)

Product:
Thunderbird
Component:
OS Integration
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 49.0

People

(Reporter: Nomis101, Assigned: Nomis101)

References

Details

Attachments

(1 file)

Patch
1.20 KB, patch
clokep
: review+
Details | Diff | Splinter Review 
As it says in the title.
Attached patch Patch — — Splinter Review 
Assignee: nobody → Nomis101

    
  
Summary: Port Bug 1271458 to Thunderbird → Port Bug 1271458 and 967970 to Thunderbird

    
  
Summary: Port Bug 1271458 and 967970 to Thunderbird → Port Bug 1271458 and Bug 967970 to Thunderbird

    
  
Depends on: 1271458, 967970

    
    

    
  
It would be good if you could give some motivation for why we should port these bugs. Is it a breakage? Some feature that we get by doing so?

    
  

        Attachment #8750868 -
        Flags: review?(Pidgeot18)

    
    

    
  
(In reply to Kent James (:rkent) from comment #2)
> It would be good if you could give some motivation for why we should port
> these bugs. Is it a breakage? Some feature that we get by doing so?

Bug 1271458 simplifies the Minimum System Version detection. The architecture specific minimum version was added at a time it was needed (in bug 589391 for FF). But it is not needed anymore and makes thinks more complicated than needed.
Bug 967970 is to prevent disk leaks and was long ago ported to SM (Bug 973644) and IB (Bug 1182380).

    
    

    
  
Comment on attachment 8750868 [details] [diff] [review]
Patch

Joshua is unlikely to get to this. I'll take a look. The attached patch seems to only port one of the bugs though?

        Attachment #8750868 -
        Flags: review?(Pidgeot18) → review?(clokep)

    
    

    
  
Comment on attachment 8750868 [details] [diff] [review]
Patch

Review of attachment 8750868 [details] [diff] [review]:
-----------------------------------------------------------------

Worked for me.

        Attachment #8750868 -
        Flags: review?(clokep) → review+

    
    

    
  
Thanks!
Keywords: checkin-needed

    
    

    
  
Please answer my question from comment 4 before checking this in.
Flags: needinfo?(Nomis101)
Keywords: checkin-needed

    
    

    
  
(In reply to Patrick Cloke [:clokep] from comment #4)
> Comment on attachment 8750868 [details] [diff] [review]
> Patch
> 
> Joshua is unlikely to get to this. I'll take a look. The attached patch
> seems to only port one of the bugs though?

The minus part is Bug 1271458 (removing LSMinimumSystemVersionByArchitecture) and the plus part is Bug 967970 (adding NSDisablePersistence).
Flags: needinfo?(Nomis101)

    
  
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: