Closed Bug 1271734 Opened 5 years ago Closed 5 years ago
Move all |mach eslint| infrastructure to tools/lint
58 bytes, text/x-review-board-request
I'm working on a linting framework that will eventually provide a common interface to all our linting. This will include eslint (though don't worry, my aim will be 100% backwards compatibility with the existing setup). Anyway, as part of that I'd like to put all lint related tools in tools/lint. The python/mach_commands.py is really meant for python related commands (like running an interactive python shell, or running python tests). Eslint doesn't belong in there. I'd also like to move the mozilla eslint plugin there too as it seems like a bit of a better fit than testing.
These two bugs are close to landing and will bitrot with this. So I'll wait for them to land before proceeding.
This commit simply moves 'testing/eslint' to 'tools/lint/eslint' and the eslint related mach command from 'python/mach_commands.py' to 'tools/lint/mach_commands.py'. It shouldn't have any functional change on running eslint, either through mach or taskcluster. This is in preparation for bug 1258341, to make the diffs there a little easier to read. Review commit: https://reviewboard.mozilla.org/r/57312/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57312/
Attachment #8759323 - Flags: review?(mratcliffe)
Hey Mike, sorry I pushed to review with the wrong bug number at first. I'm flagging you because I noticed you recently did some major eslint refactors. Let me know if I should flag someone else instead. Here is a working try run with these changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=18185937da8f
Component: General → ESLint
Comment on attachment 8759323 [details] Bug 1271734 - Move all eslint related infrastructure to tools/lint, https://reviewboard.mozilla.org/r/57312/#review55372
Attachment #8759323 - Flags: review?(mratcliffe) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/20660b425193 Move all eslint related infrastructure to tools/lint, r=miker
It would be nice to broadcast this change to platform and Firefox mailing lists, as some editors require absolute paths to the our ESLint setup, which will now need adjusting.
Sure, I'll send a note out.
You need to log in before you can comment on or make changes to this bug.