127175 - javascript strict warnings in msgReadSecurityInfo.js

Status: VERIFIED FIXED

(MailNews Core :: Security: S/MIME, defect, P2)

Description

[Stephen Walker]

Using a cvs build from today. Read a tree status message in npm.builds. View -> 
Message Security Info.

Warning: redeclaration of var l
Source File: chrome://messenger-smime/content/msgReadSecurityInfo.js
Line: 178, Column: 10
Source Code:
      var l = document.getElementById("encryptionLLabel");

Warning: redeclaration of var str
Source File: chrome://messenger-smime/content/msgReadSecurityInfo.js
Line: 183, Column: 8
Source Code:
    var str;

Comment 1

[Stephen Walker]

Attachment: patch

Comment 2

[Mitchell Stoltz (not reading bugmail)]

->PSM S/MIME

Comment 3

[Javier Delgadillo]

Comment on attachment 70866 [details] [diff] [review]
patch

r=javi

Comment 4

[Scott MacGregor]

Comment on attachment 70866 [details] [diff] [review]
patch

sr=mscott

Comment 5

[Scott MacGregor]

Comment on attachment 70866 [details] [diff] [review]
patch

one small comment, any chance we can rename the variable 'l' to something which
has a little more meaning like label?

Comment 6

[Henrik Gemal]

Stephen: could you change the l into label so we could get this one checked in?

Comment 7

[Stephen Walker]

Attachment: patch; l -> label

Comment 8

[Stephane Saux]

is this ready to check in?

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 73394 [details] [diff] [review]
patch; l -> label

a=asa (on behalf of drivers) for checkin to the 1.0 trunk and bringing the
review and super-review status forward to the current patch.

Comment 10

[Stephane Saux]

kaie.
Need to make sure the patch is compatible with the patch in bug 129100

Comment 11

[Kai Engert [:KaiE:]]

Comment on attachment 73394 [details] [diff] [review]
patch; l -> label

Sigh, I'm sorry, this patch has rotted, due to my changes with bug 129100. I'll
adjust the patch and attach a new one.

Comment 12

[Kai Engert [:KaiE:]]

Attachment: Make Patch compatible with current source

Well, the former patch changed the first half of several lines.
In the meantime, the second half of those lines changed.
Therefore, the former patch has become incompatible.
But nonetheless the changes to the first half of those lines are still required
as initially suggested, and therefore I think this patch does still have r= and
sr=.

However, due to the new checkin rules, by which apporvals expire after three
days, we need to request a= again.

Comment 13

[Kai Engert [:KaiE:]]

Checked in to trunk.

Comment 14

[Charles Rosendahl]

Verified. l is now label, but str is still str.