Closed Bug 1271758 Opened 4 years ago Closed 4 years ago
Exception gets thrown during shutdown due to inappropriate usage of set Timeout
Attachment #8750934 - Attachment mime type: text/x-patch → text/plain
This patch looks fine. Please ship if you feel confident with testing.
After talking with Andreas on IRC I will take this bug. I will try again to figure out a minimized testcase. If I can't find one in time we will land the patch as is.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/52021/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/52021/
Attachment #8751450 - Flags: review?(ato)
Comment on attachment 8751450 [details] MozReview Request: Bug 1271758 - Ensure that execute_script does not fail on closed chrome windows. r?ato Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52021/diff/1-2/
Comment on attachment 8751450 [details] MozReview Request: Bug 1271758 - Ensure that execute_script does not fail on closed chrome windows. r?ato https://reviewboard.mozilla.org/r/52021/#review49083 Please do a try run including the Mn tests.
Attachment #8751450 - Flags: review?(ato) → review+
You need to log in before you can comment on or make changes to this bug.