Closed Bug 1271784 Opened 4 years ago Closed 4 years ago

Allow WARP WebGL on Windows 7 without platform update

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed
relnote-firefox --- 48+

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file, 1 obsolete file)

ANGLE doesn't allow WARP on DXGI < 1.2 by default, but it will work fine for us.
Attached patch Allow WARP on DXGI < 1.2 (obsolete) — Splinter Review
Attachment #8750974 - Flags: review?(jgilbert)
Comment on attachment 8750974 [details] [diff] [review]
Allow WARP on DXGI < 1.2

Review of attachment 8750974 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome.
Attachment #8750974 - Flags: review?(jgilbert) → review+
Whiteboard: gfx-noted
It looks like this has the side-effect of enabling D3D11 ANGLE on our Windows 7 test machines. It's an open question as to whether we want to do this. I expect this change will probably have a negative stability impact.
This should give us D3D11 ANGLE on older versions of Windows 7 which will give a performance benefit.
Attachment #8750974 - Attachment is obsolete: true
Attachment #8751375 - Flags: review?(jgilbert)
Comment on attachment 8751375 [details] [diff] [review]
Allow D3D11 without DXGI 1.2

Review of attachment 8751375 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget to regenerate based on changes to mochitest-errata. I don't see that done here.

::: dom/canvas/test/webgl-conf/mochitest-errata.ini
@@ +75,5 @@
>  [generated/test_conformance__uniforms__uniform-default-values.html]
>  # Timeout on Windows, crash on Android/Linux.
>  skip-if = (os == 'android') || (os == 'linux') || (os == 'win')
>  [generated/test_conformance__ogles__GL__mat3__mat3_001_to_006.html]
>  # Timeout on Windows 8

s/8/non-XP/

@@ +456,2 @@
>  [generated/test_conformance__uniforms__uniform-values-per-program.html]
>  # Crashes on Windows 8 debug.

s/8/non-XP/
Attachment #8751375 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/a08a7934fdd7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Summary: Allow WARP WebGL on Windows 7 without SP 1 → Allow WARP WebGL on Windows 7 without platform update
Comment on attachment 8751375 [details] [diff] [review]
Allow D3D11 without DXGI 1.2

Approval Request Comment
[User impact if declined]: Fewer people get WebGL
[Describe test coverage new/current, TreeHerder]: Has been on Nightly for a while.
[Risks and why]: This introduces a new code path. I want to uplift this to Aurora but avoid having it ride the trains so that we get a longer period of test coverage and can get more telemetry data. Taking this will not reduce our coverage of another code path very much as currently these users will just fail to get WebGL.
Attachment #8751375 - Flags: approval-mozilla-aurora?
Assignee: nobody → jmuizelaar
Comment on attachment 8751375 [details] [diff] [review]
Allow D3D11 without DXGI 1.2

More webgl, taking it
Attachment #8751375 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backed out for the same kinds of mochitest-gl failures that got this backed out from inbound the first time around.
https://hg.mozilla.org/releases/mozilla-aurora/rev/bbabde19da55

https://treeherder.mozilla.org/logviewer.html#?job_id=2703667&repo=mozilla-aurora#L12303
Flags: needinfo?(jmuizelaar)
Awesome, just update the markings. These are good 'unexpected pass'es.
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Windows 7 computers without Platform Update can now use D3D11 WARP.
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
Relnote 49+ added "Windows 7 computers without Platform Update can now use D3D11 WARP"
This relnote should actually move from 49 to 48.
Flags: needinfo?(mozillamarcia.knous)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #19)
> This relnote should actually move from 49 to 48.

Sylvestre moved it, I see it in the 48 release notes.
Flags: needinfo?(mozillamarcia.knous)
yes, I lost network when replying to this bug ..
You need to log in before you can comment on or make changes to this bug.