1271797 - Move background color attr from Widget.TwoLinePageRow elsewhere

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This behavior was added in bug 1194033 but it doesn't really make sense – TwoLinePageRow is a generic widget and shouldn't have a default background color (e.g. this caused bug 1268603).

This attr was intended to fix the background color of the HomePanels – perhaps we should move this background color attr to a new "Widget.TwoLinePageRow.HomePanels", or similar.

bug 1268603 will add a hack fix in tab_history_item_row.xml that this bug should remove.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Looked into this: I started to add "Widget.TwoLinePageRow.HomePanel" but then I started to wonder why we had "Widget.TwoLinePageRow" anyway since it's empty. Turns out other views (e.g. BookmarksSomethingSomethingListView) inherit from that style... but it's still empty.

I asked ahunt and liuche about their opinion, at which point we decided to do some more reading to identify best practices.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1271797 - Remove hack to prevent color override in long-press back history menu. r=liuche

Review commit: https://reviewboard.mozilla.org/r/51743/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51743/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1271797 - Show explicit inheritance: Widget.RemoteTabsClientView -> Widget.TwoLinePageRow.RemoteTabsClientView. r=liuche

This is the first in a series of bugs to ...

Review commit: https://reviewboard.mozilla.org/r/51745/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51745/

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is how far I got before I paused.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.