1271887 - Crash signature containing IPC::ParamTraits<T> should not be aggregated to the generic T type

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

IPC::ParamTraits<T> is implemented for each type T that handles serialization and deserialization of the type. They usually have very different implementation and call stacks. So for example IPC::ParamTraits<mozilla::net::NetAddr>::Write is different with IPC::ParamTraits<mozilla::gfx::gfxPoint> and shouldn't be aggregated to the same IPC::ParamTraits<T>::Write crashes.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

How urgent is this?

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3343

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d7843027fb6335ffa63da05647b2d29506a84532
Fixes bug 1271887 - Do not normalize template types for IPC::ParamTraits. (#3343)

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

This is not urgent but will be nice to have it. Thanks for acting so fast! Will this landing affects the future signatures only?

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

Yes, unless we reprocess affected crash reports. It's not easy for us to do that at the moment, but we are working on automating the process in the near future. 

If reprocessing those old crash reports is important to your work, please file a new bug asking for reprocessing, ideally with a SuperSearch of the concerned reports. :)

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

https://crash-stats.mozilla.com/search/?signature=~ParamTraits&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

Adrian, new data comes in but they are still normalized.

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

That's because we had not released that code in production yet. It should work now. See this for example: https://crash-stats.mozilla.com/search/?product=Firefox&signature=%5EIPC%3A%3AParamTraits&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature