127189 - sizetopopup should set min size = popup size

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Brian Ryner (not reading)]

In order for XBL select widgets to not shrink narrower when space is
constrained, we need sizetopopup for a menulist to set the min width of the
menulist to the popup width (in addition to the preferred width).

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[jag (Peter Annema)]

Comment on attachment 70881 [details] [diff] [review]
patch

r=jag with extraneous parentheses removed.

Comment 3

[David Hyatt]

sr=hyatt (using chimera no less!)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 70881 [details] [diff] [review]
patch

a=dbaron for 0.9.9

Comment 5

[Brian Ryner (not reading)]

checked in.

Comment 6

[Brian Ryner (not reading)]

This caused a regression in the prefs dialog:

In the font panel, the dialog size isn't quite wide enough, so the menulists get
clipped instead of shrinking.  We need to come up with something better here. 
I'm backing out my checkin.

Comment 7

[Brian Ryner (not reading)]

Attachment: patch v2

Ok, let's try this again.  I'm changing the sizetopopup attribute from a
true/false value to an attribute with 3 states:

always - both the min and pref size are the popup size
pref - only the preferred size is the popup size
not set, or any other value - popup size does not affect parent content size

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 71818 [details] [diff] [review]
patch v2

r=saari (verbal)

Comment 9

[David Hyatt]

sr=hyatt

Comment 10

[Mike Shaver (:shaver emeritus)]

Comment on attachment 71818 [details] [diff] [review]
patch v2

a=shaver for 0.9.9.

Comment 11

[Brian Ryner (not reading)]

fixed, for real this time.