Closed Bug 1271903 Opened 4 years ago Closed 3 years ago

failing to build SeaMonkey on Windows loaner

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(11 obsolete files)

Currently building on the loaner using trunk results in the following
bustage:

Reticulating splines...
Traceback (most recent call last):
  File "config.status", line 988, in <module>
    config_status(**args)
  File "c:\builds\slave\c-c\build\mozilla\python\mozbuild\mozbuild\config_status.py", line 146, in config_status
    definitions = list(definitions)
  File "c:\builds\slave\c-c\build\mozilla\python\mozbuild\mozbuild\frontend\emitter.py", line 167, in emit
    for out in output:
  File "c:\builds\slave\c-c\build\mozilla\python\mozbuild\mozbuild\frontend\reader.py", line 1066, in read_mozbuild
    raise bre
mozbuild.frontend.reader.BuildReaderError:
==============================
ERROR PROCESSING MOZBUILD FILE
==============================

The error occurred while processing the following file:

    C:/builds/slave/c-c/build/mozilla/moz.build

The underlying problem is an illegal file access. This is likely due to trying to access a file outside of the top source directory.

The path whose access was denied is:

    C:/builds/slave/c-c/build/mozilla/js/src/moz.build

Modify the script to not access this file and try again.

Creating config.status
*** Fix above errors and then restart with\
               "c:/builds/slave/c-c/build/mozmake.exe -f client.mk build"
C:/builds/slave/c-c/build/client.mk:351: recipe for target 'configure' failed
mozmake.exe[1]: *** [configure] Error 1
mozmake.exe[1]: Leaving directory 'C:/builds/slave/c-c/build'
client.mk:365: recipe for target 'c:/builds/slave/c-c/build/objdir/Makefile' failed
mozmake.exe: *** [c:/builds/slave/c-c/build/objdir/Makefile] Error 2

Just filing this bug as a reminder.
After logging the build, I've tracked it to the following:

http://hg.mozilla.org/mozilla-central/file/tip/python/mozbuild/mozbuild/frontend/reader.py#l1117

1115        if mozpath.dirname(relpath) == 'js/src' and \
1116                not config.substs.get('JS_STANDALONE'):
1117            config = ConfigEnvironment.from_config_status(
1118                mozpath.join(topobjdir, reldir, 'config.status'))
1119            config.topobjdir = topobjdir
1120            config.external_source_dir = None

Prior to line 1117,  config is an object that contains (for c-c builds)
the external_source_dir attribute  (which basically points to
c-c/build).

Post-1117, external_source_dir is not defined and when it hits line
1120, it's set to None.

So, at this point, it chokes with the error stated in comment #0.

I'm wondering if resetting config.external_source_dir to c-c/build would
help?

However, when building, it hits line #1115 which is true for c-c build,
so it goes to line 1117 which essentially overwrites the existing config
object with a new one
I've made a test:

1115        if mozpath.dirname(relpath) == 'js/src' and \
1116                not config.substs.get('JS_STANDALONE'):
1117            external = config.external_source_dir
1118            config = ConfigEnvironment.from_config_status(
1119                mozpath.join(topobjdir, reldir, 'config.status'))
1120            config.topobjdir = topobjdir
1121            config.external_source_dir = external

With that, it goes further but chokes with:

Visual Studio project files (yes, IntelliSense works) by running the
following:

   mach build-backend --backend=VisualStudio

===============================
Reticulating splines...
Finished reading 3089 moz.build files in 7.95s
Processed into 10062 build config descriptors in 6.15s
RecursiveMake backend executed in 11.63s
  2938 total backend files; 2938 created; 0 updated; 0 unchanged; 0 deleted; 73
-> 1125 Makefile
FasterMake backend executed in 0.74s
  8 total backend files; 8 created; 0 updated; 0 unchanged; 0 deleted
Total wall time: 27.45s; CPU time: 27.44s; Efficiency: 100%; Untracked: 0.98s
Creating config.status
mozmake.exe[1]: Leaving directory 'C:/builds/slave/c-c/build'
c:/builds/slave/c-c/build/mozmake.exe -j4 -C c:/builds/slave/c-c/build/objdir
mozmake.exe[1]: Entering directory 'c:/builds/slave/c-c/build/objdir'
Makefile:136: *** multiple target patterns.  Stop.
mozmake.exe[1]: Leaving directory 'c:/builds/slave/c-c/build/objdir'
client.mk:394: recipe for target 'build' failed
mozmake.exe: *** [build] Error 2

The Makefile is in objdir/ and line 136 (+/- 5 lines):

129
130 define build_backend_rule
131 $(1)_files := $$(shell cat $(1).in)
132 $(1): $$($(1)_files)
133 $$($(1)_files):
134
135 endef
136 $(foreach file,$(BUILD_BACKEND_FILES),$(eval $(call build_backend_rule,$(file))))
137
138 default:: $(BUILD_BACKEND_FILES)
139 endif

and if I add "$(info $(1))" before line 131, I get:

 MAPI Headers;c:\\Program Files (x86)\\Windows Kits\\8.1\\include\\winrt
    export MOZ_OBJDIR=c:/builds/slave/c-c/build/objdir
    export TOOLTOOL_DIR=c:\\\\builds\\\\slave\\\\c-c\\\\build
    FOUND_MOZCONFIG := C:/builds/slave/c-c/build/.mozconfig
c:/builds/slave/c-c/build/mozmake.exe -j4 -C c:/builds/slave/c-c/build/objdir
mozmake.exe[1]: Entering directory 'c:/builds/slave/c-c/build/objdir'
backend.RecursiveMakeBackend
Makefile:140: *** multiple target patterns.  Stop.
mozmake.exe[1]: Leaving directory 'c:/builds/slave/c-c/build/objdir'
client.mk:394: recipe for target 'build' failed
pymake\..\..\mozmake.exe: *** [build] Error 2

So, something within backend.RecursiveMakeBackend is choking it.
c-a is also giving me some trouble as well.
going into build/objdir, I do
|..\mozmake.exe --trace -d|, I get:

GNU Make 4.0-43-g8411528
Built for Windows32
Copyright (C) 1988-2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
find_and_set_shell() path search set default_shell = C:/mozilla-build/msys/bin/sh.exe
Reading makefiles...
Reading makefile 'Makefile'...
Reading makefile 'config/autoconf.mk' (search path) (no ~ expansion)...
Reading makefile 'config/emptyvars.mk' (search path) (no ~ expansion)...
Reading makefile 'C:/builds/slave/c-c/build/mozilla/config/baseconfig.mk' (search path) (no ~ expansion)...
Reading makefile 'C:/builds/slave/c-c/build/mozilla/../suite/build.mk' (search path) (no ~ expansion)...
Reading makefile 'C:/builds/slave/c-c/build/mozilla/config/config.mk' (search path) (no ~ expansion)...
Reading makefile '.mozconfig.mk' (search path) (don't care) (no ~ expansion)...
Reading makefile 'backend.mk' (search path) (no ~ expansion)...
Reading makefile 'C:/builds/slave/c-c/build/mozilla/defs.mk' (search path) (don't care) (no ~ expansion)...
Reading makefile 'C:/builds/slave/c-c/build/mozilla/config/makefiles/functions.mk' (search path) (no ~ expansion)...
Reading makefile 'C:/builds/slave/c-c/build/mozilla/config/static-checking-config.mk' (search path) (no ~ expansion)...
Reading makefile 'C:/builds/slave/c-c/build/mozilla/../suite/app-config.mk' (search path) (don't care) (no ~ expansion)...
Reading makefile 'config/myconfig.mk' (search path) (don't care) (no ~ expansion)...
CreateProcess(C:\mozilla-build\msys\bin\cat.exe,cat backend.RecursiveMakeBackend.in,...)
Main thread handle = 00000090
Makefile:136: *** multiple target patterns.  Stop.

and I'll attach the backend.RecursiveMakeBackend.in file.
Attached file backend.RecursiveMakeBackend.in (obsolete) —
resulting backend.RecursiveMakeBackend.in
Comment on attachment 8755357 [details]
backend.RecursiveMakeBackend.in

Ah.. I think I found where it's choking:

line 2248 to 2255:

C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/build/common.gypi
C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/build/filename_rules.gypi
C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/build/internal/release_defaults.gypi
C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/build/internal/release_impl.gypi
C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/build/internal/release_impl_official.gypi
C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/build/release.gypi
C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/supplement/supplement.gypi
C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/webrtc/supplement.gypi


now to find out why it's adding the extra c:/
Attachment #8755357 - Attachment is obsolete: true
Attached patch test patch (obsolete) — Splinter Review
With the attached test patch, I get the following errors:

c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fostrpbrk.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/libc -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/libc -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/lib/libc/src/strpbrk.c
c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fontmisc.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/ntmisc.c
Unified_cpp_dom_cellbroadcast0.cpp
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(401): error C2065: 'jsval_layout': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(401): error C2338: JS_STATIC_ASSERT
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1025): error C2065: 'jsval_layout': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1025): error C2146: syntax error: missing ')' before identifier 'l'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1026): error C2143: syntax error: missing ';' before '{'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1026): error C2447: '{': missing function header (old-style formal list?)
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1030): error C2433: 'jsval_layout': 'inline' not permitted on data declarations
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1030): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1030): error C2146: syntax error: missing ';' before identifier 'JSVAL_TO_IMPL'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1031): error C2146: syntax error: missing ')' before identifier 'l'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1457): error C3646: 'data': unknown override specifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1457): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1471): error C2061: syntax error: identifier 'JSVAL_TO_IMPL'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1471): error C2091: function returns function
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1471): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1472): error C2039: 'IMPL_TO_JSVAL': is not a member of '`global namespace''
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1472): error C2061: syntax error: identifier 'jsval_layout'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1119): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1119): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1119): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1119): error C2065: 'JSVAL_TAG_NULL': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1119): error C3861: 'BUILD_JSVAL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1123): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1123): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1123): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1123): error C2065: 'JSVAL_TAG_UNDEFINED': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1123): error C3861: 'BUILD_JSVAL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1127): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1127): error C3861: 'INT32_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1132): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1132): error C2228: left of '.s' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1132): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1132): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1132): error C2228: left of '.i32' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1136): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1136): error C3861: 'DOUBLE_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1145): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1145): error C2228: left of '.asDouble' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1145): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1149): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1149): error C3861: 'STRING_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1153): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1153): error C3861: 'SYMBOL_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1157): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1157): error C3861: 'OBJECT_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1161): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1161): error C3861: 'BOOLEAN_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1165): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1165): error C3861: 'MAGIC_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1169): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1169): error C3861: 'MAGIC_UINT32_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1201): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1096): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1201): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1202): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1096): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1202): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1202): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1203): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1203): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1203): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1209): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1209): error C3861: 'JSVAL_IS_UNDEFINED_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1213): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1213): error C3861: 'JSVAL_IS_NULL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1221): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1221): error C3861: 'JSVAL_IS_INT32_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1225): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1225): error C3861: 'JSVAL_IS_SPECIFIC_INT32_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1229): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1229): error C3861: 'JSVAL_IS_DOUBLE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1233): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1233): error C3861: 'JSVAL_IS_NUMBER_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1237): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1237): error C3861: 'JSVAL_IS_STRING_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C3861: 'JSVAL_IS_SYMBOL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1245): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1245): error C3861: 'JSVAL_IS_OBJECT_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1249): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1249): error C3861: 'JSVAL_IS_PRIMITIVE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1253): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1253): error C3861: 'JSVAL_IS_OBJECT_OR_NULL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1257): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1257): error C3861: 'JSVAL_IS_GCTHING_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1261): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1261): error C3861: 'JSVAL_IS_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1265): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1265): error C3861: 'JSVAL_IS_SPECIFIC_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1269): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1269): error C3861: 'JSVAL_IS_SPECIFIC_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1273): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1273): error C3861: 'JSVAL_IS_MAGIC_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1278): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1278): error C3861: 'JSVAL_IS_MAGIC_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1282): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1282): error C3861: 'JSVAL_IS_TRACEABLE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1287): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1287): error C3861: 'JSVAL_TRACE_KIND_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1292): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1292): error C2228: left of '.s' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1292): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1292): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1292): error C2228: left of '.why' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1297): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1297): error C2228: left of '.s' must hstrpbrk.c
ave class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1297): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1297): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1297): error C2228: left of '.u32' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1303): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1303): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1303): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1303): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1096): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1307): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1307): fatal error C1003: error count exceeds 100; stopping compilation
c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fostrstr.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/libc -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/libc -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/lib/libc/src/strstr.c
C:/builds/slave/c-c/build/mozilla/config/rules.mk:934: recipe for target 'Unified_cpp_dom_cellbroadcast0.obj' failed
mozmake.exe[4]: *** [Unified_cpp_dom_cellbroadcast0.obj] Error 2
mozmake.exe[4]: Leaving directory 'c:/builds/slave/c-c/build/objdir/dom/cellbroadcast'
I'm getting the result of comment #8 probably because of the test patch
(I'm guessing the changing of the config.external_source_dir).

the gyp_reader.py change isn't right as it screws up m-c's windows build,
as demonstrated in https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdc9cc11f59a4dbd938066e3c5266f7a4af300ed

I'm completely stumped.

:glandium, sorry to bother you, but would it be possible if you could
enlighten me how I can go about in fixing this?
Flags: needinfo?(mh+mozilla)
The most critical information is missing:

> Currently building on the loaner using trunk results in the following bustage:

What kind of loaner, and how are you starting your build?
Flags: needinfo?(mh+mozilla)
(I'm asking, because on an AWS ec2 instance with start-shell-msvc2015.bat, cloning comm-central, running client.py checkout, then running ./mozilla/mach configure --enable-project=suite, and finally ./mozilla/mach build, I don't have weird paths in backend.RecursiveMakeBackend.in (the build however fails because I don't have the MAPI headers)
(In reply to Mike Hommey [:glandium] from comment #10)
> The most critical information is missing:
> 
> > Currently building on the loaner using trunk results in the following bustage:
> 
> What kind of loaner, and how are you starting your build?

it's a Win2008 R2 loaner.  I'm starting my build via:

|python c:/builds/%SLAVE%/%INTREEPATH%/build/build/pymake/make.py -f client.mk MOZ_BUILD_DATE=%BUILDID% 2>&1 | tee ./build.log|

as that's what the builders do.
(In reply to Edmund Wong (:ewong) from comment #12)
> (In reply to Mike Hommey [:glandium] from comment #10)
> > The most critical information is missing:
> > 
> > > Currently building on the loaner using trunk results in the following bustage:
> > 
> > What kind of loaner, and how are you starting your build?
> 
> it's a Win2008 R2 loaner.  I'm starting my build via:
> 
> |python c:/builds/%SLAVE%/%INTREEPATH%/build/build/pymake/make.py -f
> client.mk MOZ_BUILD_DATE=%BUILDID% 2>&1 | tee ./build.log|
> 
> as that's what the builders do.

oh forgot to mention, this is in a command prompt via cmd.
what environment variables are set, and to what value?
BTW, pymake/make.py has been nothing more than a wrapper that calls mozmake for 2 years now. You should call mozmake directly.
(In reply to Mike Hommey [:glandium] from comment #14)
> what environment variables are set, and to what value?

ALLUSERSPROFILE=C:\ProgramData
APPDATA=C:\Users\cltbld\AppData\Roaming
APR_ICONV_PATH=c:/mozilla-build/svn-win32-1.6.3/iconv
BASEDIR=/c/builds/slave/c-c
BASEURL=http://upload.seabld.productdelivery.prod.mozaws.net/pub/seamonkey/nightly/latest-comm-central-trunk/mar-tools/win32
BUILDDIR=c-c
BUILDID=20160525231445
BUILD_PATH=nightly
ChocolateyInstall=C:\ProgramData\chocolatey
CommonProgramFiles=C:\Program Files (x86)\Common Files
CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files
CommonProgramW6432=C:\Program Files\Common Files
COMMON_PATH=common
COMPUTERNAME=b-2008-ec2-ewong
ComSpec=C:\windows\system32\cmd.exe
CTREE=comm-central
CVS_RSH=ssh
DCLOCATION=SCL3
DXSDK_DIR=C:\Tools\sdks\dx10\
EDITOR=emacs.exe --no-window-system
FP_NO_HOST_CHECK=NO
FTPTREENAME=latest-comm-central-trunk
HG_SHARE_BASE_DIR=c:/builds/hg-shared
HOME=c:/Users/cltbld
HOMEDRIVE=C:
HOMEPATH=\
HOSTTYPE=i686
INPUTRC=C:/mozilla-build/msys/etc/inputrc
INTREEPATH=c-c
IS_NIGHTLY=yes
KTS_HOME=C:\Program Files\KTS
KTS_VERSION=1.19c
LOCALAPPDATA=C:\Users\cltbld\AppData\Local
LOG="c:\tmp\buildbot-startup.log"
LOGNAME=cltbld
LOGONSERVER=\\B-2008-EC2-EWON
MACHTYPE=i686-pc-msys
MAKE_MODE=unix
MOZBUILDDIR=C:\mozilla-build\
MOZCONFIGS=mozconfigs
MOZILLABUILD=C:\mozilla-build\
MOZ_AUTOMATION=1
MOZ_CRASHREPORTER_NO_REPORT=1
MOZ_OBJDIR=/c/builds/slave/c-c/build/objdir
MOZ_TOOLS=C:\mozilla-build\\moztools-x64
MOZ_UPDATE_CHANNEL=nightly
MREVISION=8d0aadfe7da7
MSYSTEM=MINGW32
MTREE=mozilla-central
NUMBER_OF_PROCESSORS=4
OLDPATH=..\\nightly
OLDPWD=c:/Users/cltbld
OLDTREEPATH=c-c
OS=Windows_NT
OSTYPE=msys
os_version=2008
Path=C:\mozilla-build\nsis-3.0b1;C:\mozilla-build\nsis-2.46u;C:\mozilla-build\python27;C:\mozilla-build\buildbotve\scripts;C:\mozilla-build\msys\local\bin;c:\mozilla-build\wget;c:\mozilla-build\7zip;c:\mozilla-build\blat261\full;c:\mozilla-build\python;c:\mozilla-build\svn-win32-1.6.3\bin;c:\mozilla-build\upx203w;c:\mozilla-build\emacs-22.3\bin;c:\mozilla-build\info-zip;c:\mozilla-build\nsis-2.22;c:\mozilla-build\nsis-2.33u;c:\mozilla-build\nsis-2.46u;c:\mozilla-build\wix-351728;c:\mozilla-build\hg;c:\mozilla-build\python\Scripts;c:\mozilla-build\kdiff3;c:\mozilla-build\yasm;.;C:\mozilla-build\msys\local\bin;C:\mozilla-build\msys\mingw\bin;C:\mozilla-build\msys\bin;c:\windows\system32;c:\windows;c:\windows\System32\Wbem;c:\windows\System32\WindowsPowerShell\v1.0\;c:\mozilla-build;c:\mozilla-build\python27;c:\mozilla-build\python27\Scripts;C:\mozilla-build\msys\bin;c:\mozilla-build\vim\vim72;c:\mozilla-build\wget;c:\mozilla-build\info-zip;c:\CoreUtils\bin;c:\mozilla-build\buildbotve\scripts;c:\Program Files (x86)\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files\Microsoft SQL Server\100\DTS\Binn\;c:\Program Files (x86)\Windows Kits\8.0\Windows Performance Toolkit\;c:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit\;c:\Program Files\Microsoft SQL Server\110\Tools\Binn\;c:\Program Files (x86)\Microsoft SDKs\TypeScript\1.0\;c:\mozilla-build\hg;c:\ipmitools;c:\ipmitools;c:\mozilla-build\moztools-x64\bin;c:\mozilla-build\vim\vim72
PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
PDBSTR_PATH=/c/Program Files (x86)/Windows Kits/8.0/Debuggers/x64/srcsrv/pdbstr.exe
POST_SYMBOL_UPLOAD_CMD=/usr/local/bin/post-symbol-upload.py
PROCESSOR_ARCHITECTURE=x86
PROCESSOR_ARCHITEW6432=AMD64
PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 30 Stepping 5, GenuineIntel
PROCESSOR_LEVEL=6
PROCESSOR_REVISION=1e05
ProgramData=C:\ProgramData
ProgramFiles=C:\Program Files (x86)
ProgramFiles(x86)=C:\Program Files (x86)
ProgramW6432=C:\Program Files
PROMPT=$P$G
PSModulePath=C:\windows\system32\WindowsPowerShell\v1.0\Modules\
PUBLIC=C:\Users\Public
PWD=c:/Users/cltbld
RELPATH=..\
REVISION=664eff8ea96f
SESSIONNAME=Console
SHELL=C:/mozilla-build/msys/bin/sh
SHLVL=1
SLAVE=slave
STEP10TREENAME=comm-central-trunk
SystemDrive=C:
SystemRoot=C:\windows
TEMP=C:/Users/cltbld/AppData/Local/Temp
TERM=cygwin
TEST1=testie
TINDERBOX_OUTPUT=1
TMP=C:/Users/cltbld/AppData/Local/Temp
TOOLSDIR=/c/builds/slave/c-c/tools
TREE=comm-central
TREENAME=latest-comm-central
TREEPATH=..\\c-c
USERDOMAIN=B-2008-IX-0076
USERNAME=cltbld
USERPROFILE=C:\Users\cltbld
VS100COMNTOOLS=c:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools\
VS110COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\Tools\
VS120COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\Tools\
windir=C:\windows
windows_tracing_flags=3
windows_tracing_logfile=C:\BVTBin\Tests\installpackage\csilogfile.log
WIX_351728_PATH=c:/mozilla-build/wix-351728
(In reply to Edmund Wong (:ewong) from comment #16)
> BASEDIR=/c/builds/slave/c-c
> MOZ_OBJDIR=/c/builds/slave/c-c/build/objdir
> TOOLSDIR=/c/builds/slave/c-c/tools

You should clearly start by changing those to use c:/...
(In reply to Mike Hommey [:glandium] from comment #17)
> (In reply to Edmund Wong (:ewong) from comment #16)
> > BASEDIR=/c/builds/slave/c-c
> > MOZ_OBJDIR=/c/builds/slave/c-c/build/objdir
> > TOOLSDIR=/c/builds/slave/c-c/tools
> 
> You should clearly start by changing those to use c:/...

ah right.  Did that, but still getting the results from comment #0
Attached file build log (obsolete) —
this is the build log
Attached file environment vars. (obsolete) —
This is the env vars during build.
Attached file environment vars. (obsolete) —
Attachment #8757590 - Attachment is obsolete: true
Windows is still not building but I'm feeling it might be
related to bug 1214705.
Attached file environment vars. (obsolete) —
Attachment #8757594 - Attachment is obsolete: true
Having tried to build this for some time and not working, my mind
isn't clear as to what's going on.

Given the build log and the existing env. vars,  and with the added changes
in the .mozconfig to look exactly like :

http://hg.mozilla.org/comm-central/file/tip/mail/config/mozconfigs/win32/nightly

(minus the telemetry stuff and addon signing, and clientpy args)

still ends with what I got with comment #0.  and if I patch python/mozbuild/mozbuild/frontend/reader.py (as in the test patch), it basically chokes with
the multiple pattern.
Comment on attachment 8756675 [details] [diff] [review]
test patch

glandium: is it right to have the config to become a new ConfigEnvironment
without caring about the config.external_source_dir prior to the "if mozpath.dirname(...)" line, which could have config.external_source_dir?

With the above patch, it breaks with:


  8 total backend files; 8 created; 0 updated; 0 unchanged; 0 deleted
VisualStudio backend executed in 3.25s
Generated Visual Studio solution at c:/builds/slave/c-c/build/objdir\msvc\mozilla.sln
Total wall time: 30.97s; CPU time: 30.97s; Efficiency: 100%; Untracked: 1.00s
Creating config.status
mozmake.exe[1]: Leaving directory 'C:/builds/slave/c-c/build'
c:/builds/slave/c-c/build/mozmake.exe -j8 -C c:/builds/slave/c-c/build/objdir
mozmake.exe[1]: Entering directory 'c:/builds/slave/c-c/build/objdir'
Makefile:136: *** multiple target patterns.  Stop.
mozmake.exe[1]: Leaving directory 'c:/builds/slave/c-c/build/objdir'
client.mk:394: recipe for target 'build' failed
mozmake.exe: *** [build] Error 2

Which I've traced to :

http://hg.mozilla.org/mozilla-central/file/tip/python/mozbuild/mozbuild/frontend/gyp_reader.py#l115

which 'does something' to some of the paths that seem to use c:/.. 
i.e. 

C:/c:builds/slave/c-c/build/mozilla/media/webrtc/trunk/build/common.gypi

Following the tracing, I come across the following print statement
(when I do a print statement after line #139 )

(u'  gyp_reader: 116: target = ', 'C:\\builds\\slave\\c-c\\build\\mozilla\\media\\webrtc\\signaling\\signaling.gyp:ecc#target')
(u'    gyp_reader: 139: f', 'signaling.gyp')
(u'    gyp_reader: 139: f', '..\\..\\..\\..\\..\\..\\..\\..\\..\\c:builds\\slave\\c-c\\build\\mozilla\\media\\webrtc\\trunk\\build\\common.gypi')


Any changes to that above line will break m-c (tested it).

I've been banging my head against this.  glandium,  would you happen
to have an idea or two how to find which part of the build env that's
busting?
Flags: needinfo?(mh+mozilla)
adding the following hack to gyp_reader:

diff --git a/python/mozbuild/mozbuild/frontend/gyp_reader.py b/python/mozbuild/mozbuild/frontend/gyp_reader.py
--- a/python/mozbuild/mozbuild/frontend/gyp_reader.py
+++ b/python/mozbuild/mozbuild/frontend/gyp_reader.py
@@ -133,6 +133,8 @@ def read_from_gyp(config, path, output, 
         context.add_source(mozpath.abspath(build_file))
         # The list of included files returned by gyp are relative to build_file
         for f in data[build_file]['included_files']:
+            if 'c:' in f:
+                f = f.replace('c:', '')
             context.add_source(mozpath.abspath(mozpath.join(
                 mozpath.dirname(build_file), f)))
 
produces the following:

c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fow32poll.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/w32poll.c
ntinrval.c
c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fow32rng.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/w32rng.c
ntsec.c
c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fow32shm.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/w32shm.c
Unified_cpp_dom_xslt_xpath1.cpp
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(339): error C2065: 'jsval_layout': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(339): error C2338: JS_STATIC_ASSERT
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(963): error C2065: 'jsval_layout': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(963): error C2146: syntax error: missing ')' before identifier 'l'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(964): error C2143: syntax error: missing ';' before '{'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(964): error C2447: '{': missing function header (old-style formal list?)
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(968): error C2433: 'jsval_layout': 'inline' not permitted on data declarations
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(968): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(968): error C2146: syntax error: missing ';' before identifier 'JSVAL_TO_IMPL'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(969): error C2146: syntax error: missing ')' before identifier 'l'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1395): error C3646: 'data': unknown override specifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1395): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1409): error C2061: syntax error: identifier 'JSVAL_TO_IMPL'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1409): error C2091: function returns function
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1409): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1410): error C2039: 'IMPL_TO_JSVAL': is not a member of '`global namespace''
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1410): error C2061: syntax error: identifier 'jsval_layout'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C2065: 'JSVAL_TAG_NULL': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C3861: 'BUILD_JSVAL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C2065: 'JSVAL_TAG_UNDEFINED': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C3861: 'BUILD_JSVAL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1065): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1065): error C3861: 'INT32_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2228: left of '.s' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2228: left of '.i32' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1074): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1074): error C3861: 'DOUBLE_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1083): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1083): error C2228: left of '.asDouble' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1083): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1087): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1087): error C3861: 'STRING_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1091): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1091): error C3861: 'SYMBOL_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1095): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1095): error C3861: 'OBJECT_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1099): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1099): error C3861: 'BOOLEAN_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1103): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1103): error C3861: 'MAGIC_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1107): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1107): error C3861: 'MAGIC_UINT32_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1139): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1034): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1139): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1140): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1034): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1140): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1140): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1141): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1141): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1141): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1147): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1147): error C3861: 'JSVAL_IS_UNDEFINED_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1151): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1151): error C3861: 'JSVAL_IS_NULL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1159): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1159): error C3861: 'JSVAL_IS_INT32_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1163): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1163): error C3861: 'JSVAL_IS_SPECIFIC_INT32_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1167): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\ntsem.c
ntmisc.c
C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/ntmisc.c(820): warning C4996: 'GetVersionExA': was declared deprecated
c:\builds\slave\c-c\build\vs2015u2\SDK\Include\um\sysinfoapi.h(450): note: see declaration of 'GetVersionExA'
C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/ntmisc.c(871): warning C4996: 'GetVersionExA': was declared deprecated
c:\builds\slave\c-c\build\vs2015u2\SDK\Include\um\sysinfoapi.h(450): note: see declaration of 'GetVersionExA'
js/Value.h(1167): error C3861: 'JSVAL_IS_DOUBLE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1171): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1171): error C3861: 'JSVAL_IS_NUMBER_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1175): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1175): error C3861: 'JSVAL_IS_STRING_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1179): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1179): error C3861: 'JSVAL_IS_SYMBOL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1183): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1183): error C3861: 'JSVAL_IS_OBJECT_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1187): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1187): error C3861: 'JSVAL_IS_PRIMITIVE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1191): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1191): error C3861: 'JSVAL_IS_OBJECT_OR_NULL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1195): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1195): error C3861: 'JSVAL_IS_GCTHING_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1199): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1199): error C3861: 'JSVAL_IS_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1203): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1203): error C3861: 'JSVAL_IS_SPECIFIC_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1207): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1207): error C3861: 'JSVAL_IS_SPECIFIC_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1211): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1211): error C3861: 'JSVAL_IS_MAGIC_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1216): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1216): error C3861: 'JSVAL_IS_MAGIC_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1220): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1220): error C3861: 'JSVAL_IS_TRACEABLE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1225): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1225): error C3861: 'JSVAL_TRACE_KIND_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2228: left of '.s' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2228: left of '.why' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2228: left of '.s' must have class/sc:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fow95cv.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/w95cv.c
w32ipcsem.c
c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fow95dllmain.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/w95dllmain.c
c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fow95io.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/w95io.c
truct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2228: left of '.u32' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1034): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1245): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1245): fatal error C1003: error count exceeds 100; stopping compilation
Unified_cpp_dom_xslt_xpath2.cpp
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(339): error C2065: 'jsval_layout': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(339): error C2338: JS_STATIC_ASSERT
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(963): error C2065: 'jsval_layout': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(963): error C2146: syntax error: missing ')' before identifier 'l'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(964): error C2143: syntax error: missing ';' before '{'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(964): error C2447: '{': missing function header (old-style formal list?)
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(968): error C2433: 'jsval_layout': 'inline' not permitted on data declarations
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(968): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(968): error C2146: syntax error: missing ';' before identifier 'JSVAL_TO_IMPL'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(969): error C2146: syntax error: missing ')' before identifier 'l'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1395): error C3646: 'data': unknown override specifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1395): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1409): error C2061: syntax error: identifier 'JSVAL_TO_IMPL'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1409): error C2091: function returns function
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1409): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1410): error C2039: 'IMPL_TO_JSVAL': is not a member of '`global namespace''
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1410): error C2061: syntax error: identifier 'jsval_layout'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C2065: 'JSVAL_TAG_NULL': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1057): error C3861: 'BUILD_JSVAL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C2065: 'JSVAL_TAG_UNDEFINED': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1061): error C3861: 'BUILD_JSVAL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1065): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1065): error C3861: 'INT32_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2228: left of '.s' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1070): error C2228: left of '.i32' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1074): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1074): error C3861: 'DOUBLE_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1083): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1083): error C2228: left of '.asDouble' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1083): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1087): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1087): error C3861: 'STRING_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1091): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1091): error C3861: 'SYMBOL_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1095): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1095): error C3861: 'OBJECT_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1099): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1099): error C3861: 'BOOLEAN_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1103): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1103): error C3861: 'MAGIC_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1107): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1107): error C3861: 'MAGIC_UINT32_TO_JSVAL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1139): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1034): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1139): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1140): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1034): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1140): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1140): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1141): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1141): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1141): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1147): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1147): error C3861: 'JSVAL_IS_UNDEFINED_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1151): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1151): error C3861: 'JSVAL_IS_NULL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1159): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1159): error C3861: 'JSVAL_IS_INT32_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1163): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1163): error C3861: 'JSVAL_IS_SPECIFIC_INT32_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1167): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\C:/builds/slave/c-c/build/mozilla/config/rules.mk:934: recipe for target 'Unified_cpp_dom_xslt_xpath1.obj' failed
mozmake.exe[4]: *** [Unified_cpp_dom_xslt_xpath1.obj] Error 2
c:/builds/slave/c-c/build/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/slave/c-c/build/vs2015u2/VC/bin/amd64_x86/cl.EXE -Fow95sock.obj -c  -DNDEBUG=1 -DTRIMMED=1 -D_NSPR_BUILD_ -DWIN32 -DXP_PC -D_PR_GLOBAL_THREADS_ONLY -DWIN95 -UWINNT -D_X86_ -IC:/builds/slave/c-c/build/mozilla/config/external/nspr/pr -Ic:/builds/slave/c-c/build/objdir/config/external/nspr/pr -IC:/builds/slave/c-c/build/mozilla/config/external/nspr -IC:/builds/slave/c-c/build/mozilla/nsprpub/pr/include -IC:/builds/js/Value.h(1167): error C3861: 'JSVAL_IS_DOUBLE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1171): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1171): error C3861: 'JSVAL_IS_NUMBER_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1175): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1175): error C3861: 'JSVAL_IS_STRING_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1179): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1179): error C3861: 'JSVAL_IS_SYMBOL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1183): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1183): error C3861: 'JSVAL_IS_OBJECT_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1187): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1187): error C3861: 'JSVAL_IS_PRIMITIVE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1191): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1191): error C3861: 'JSVAL_IS_OBJECT_OR_NULL_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1195): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1195): error C3861: 'JSVAL_IS_GCTHING_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1199): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1199): error C3861: 'JSVAL_IS_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1203): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1203): error C3861: 'JSVAL_IS_SPECIFIC_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1207): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1207): error C3861: 'JSVAL_IS_SPECIFIC_BOOLEAN_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1211): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1211): error C3861: 'JSVAL_IS_MAGIC_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1216): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1216): error C3861: 'JSVAL_IS_MAGIC_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1220): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1220): error C3861: 'JSVAL_IS_TRACEABLE_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1225): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1225): error C3861: 'JSVAL_TRACE_KIND_IMPL': identifier not found
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2228: left of '.s' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1230): error C2228: left of '.why' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2228: left of '.s' must have class/sslave/c-c/build/mozilla/nsprpub/pr/include/private -Ic:/builds/slave/c-c/build/objdir/dist/include  -Ic:/builds/slave/c-c/build/objdir/dist/include/nspr -Ic:/builds/slave/c-c/build/objdir/dist/include/nss        -MD -FI c:/builds/slave/c-c/build/objdir/mozilla-config.h -DMOZILLA_CLIENT   -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:SSE2 -FS -wd4244 -wd4267 -wd4819 -we4553  -Zi -O1 -Oi -Oy-  -Fdgenerated.pdb  C:/builds/slave/c-c/build/mozilla/nsprpub/pr/src/md/windows/w95sock.c
truct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2228: left of '.payload' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1235): error C2228: left of '.u32' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C2228: left of '.asBits' must have class/struct/union
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): note: type is 'unknown-type'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1241): error C2039: 'data': is not a member of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1034): note: see declaration of 'JS::Value'
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1245): error C2065: 'data': undeclared identifier
c:\builds\slave\c-c\build\objdir\dist\include\js/Value.h(1245): fatal error C1003: error count exceeds 100; stopping compilation
C:/builds/slave/c-c/build/mozilla/config/rules.mk:934: recipe for target 'Unified_cpp_dom_xslt_xpath2.obj' failed
mozmake.exe[4]: *** [Unified_cpp_dom_xslt_xpath2.obj] Error 2
mozmake.exe[4]: Leaving directory 'c:/builds/slave/c-c/build/objdir/dom/xslt/xpath'
C:/builds/slave/c-c/build/mozilla/config/recurse.mk:71: recipe for target 'dom/xslt/xpath/target' failed
mozmake.exe[3]: *** [dom/xslt/xpath/target] Error 2
Is the build PC using the latest mozilla build enviroinment? Not sure if this matters but I didn't see nsis-3.0b3 and so it might still be 2.1 and not 2.2.
I am also having a MSYS_MOZBUILD=/c/mozilla-build in my env.
(In reply to Frank-Rainer Grahl from comment #28)
> I am also having a MSYS_MOZBUILD=/c/mozilla-build in my env.

nope. No difference.  I've also changed it to use python instead
of the full path python27, and I'm using an upgraded Mozilla-build.

I have still no clue why TB isn't busted.
Attached file [code from Feb 2nd 2016] (obsolete) —
This build log uses [c-c: 7dc7d3425d45],
                    [m-c: 4295f9951e93].

It busts 'normally' with the following (fixable) error:

C:/builds/slave/c-c/build/suite/profile/nsSuiteDirectoryProvider.cpp(31) : error C2065: 'NS_APP_BOOKMARKS_50_FILE' : undeclared identifier
C:/builds/slave/c-c/build/suite/profile/nsSuiteDirectoryProvider.cpp(115) : error C2065: 'NS_APP_PROFILE_DEFAULTS_50_DIR' : undeclared identifier
C:/builds/slave/c-c/build/mozilla/config/rules.mk:967: recipe for target 'nsSuiteDirectoryProvider.obj' failed
Attachment #8768289 - Attachment description: build log :[c-c: 7dc7d3425d45], [m-c: 4295f9951e93] → [code from Feb 2nd 2016]
fwiw, I am going through Thunderbird's nightly build logs to get their
c-c and m-c csets and just did the Feb. 2nd 2016 one.
The above is Bug 1238428. Also see followup bug 1240798 but this one is not needed to get things going and not yet ready anyway. Without it some non essential files are not copied to a new profile.

FRG
(In reply to Frank-Rainer Grahl from comment #32)
> The above is Bug 1238428. Also see followup bug 1240798 but this one is not
> needed to get things going and not yet ready anyway. Without it some non
> essential files are not copied to a new profile.
> 
> FRG

right.  now aside for the bustage caused by not finding project 'suite'
(can't remember the bug #), the csets that first busted with this bug
is c-c: 8cf423dd5f47  and m-c: 6202ade0e6d6.

The first good build cset: c-c: afc38db4e0ef, m-c: 5a2e0878d6c2

looking at the csets and figuring out which change broke suite/.

otr:

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2016-03-04&enddate=2016-03-24
My Money would be on Bug 1253203 and followups in c-c and m-c. This broke c-c building for some time and needed a lot of fixes even locally.

FRG
Attached patch proposed patch (v1) (obsolete) — Splinter Review
this patch unhorks the windows build.  I've also pushed this to
try via https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fcdc9ac9a7ca60d6588a44e2c52e224f4a4ee56
Assignee: nobody → ewong
Attachment #8756675 - Attachment is obsolete: true
Attachment #8757589 - Attachment is obsolete: true
Attachment #8757754 - Attachment is obsolete: true
Attachment #8768289 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Comment on attachment 8769407 [details] [diff] [review]
proposed patch (v1)

this is a proposed patch. 

Yes, the word 'hack' comes to mind; but it unhorks the windows
build. 

Apparently the change in http://hg.mozilla.org/mozilla-central/rev/49f9aa2b50f0 made
the path sensitivity levels a lot higher than c-c can cope.  
(my interpretation of the bustage) as the cset before that in
http://hg.mozilla.org/mozilla-central/rev/f08207e3060c,
it didn't fail.
Attachment #8769407 - Flags: review?(mh+mozilla)
(In reply to Edmund Wong (:ewong) from comment #35)
> Created attachment 8769407 [details] [diff] [review]
> proposed patch (v1)
> 
> this patch unhorks the windows build.  I've also pushed this to
> try via
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=8fcdc9ac9a7ca60d6588a44e2c52e224f4a4ee56

Looks like it's green
Flags: needinfo?(mh+mozilla)
Attached patch c-c patch (obsolete) — Splinter Review
If this patch is reviewed and ok'd, then there's no need for the 
proposed patch to m-c (and the subsequent requirements of pushing
to m-a to m-b).

tbh, this is more of a workaround to get the builds (suite) building.
Once suite/ has a more-permanent Win32/64 builders, we can do-away with
this patch.    TB isn't affected (haven't yet determined why) but
basically, the issue revolves around TOPSRCDIR having "C:/builds/slave..."
and something in m-c doesn't like that.   Lower-casing the C: allows
the build to continue.

I think this is a patch that might be a better idea than fidging with
m-c's build config with hacks.
Attachment #8769598 - Flags: review?(bugspam.Callek)
Attachment #8769598 - Flags: review?(Pidgeot18)
Attachment #8769598 - Flags: feedback?(mh+mozilla)
Comment on attachment 8769598 [details] [diff] [review]
c-c patch

I'm going to defer to jcranmer review and glandium's feedback on this. It looks sane, but makes me wonder if there isn't a cleaner solution.
Attachment #8769598 - Flags: review?(bugspam.Callek)
Attached patch c-c patch (v2) (obsolete) — Splinter Review
Instead of having a repeated check for windows to set the  TOPSRCDIR properly, we might as well use the existing windows check.
Attachment #8769598 - Attachment is obsolete: true
Attachment #8769598 - Flags: review?(Pidgeot18)
Attachment #8769598 - Flags: feedback?(mh+mozilla)
Attachment #8769900 - Flags: review?(Pidgeot18)
Attachment #8769900 - Flags: feedback?(mh+mozilla)
Comment on attachment 8769900 [details] [diff] [review]
c-c patch (v2)

Review of attachment 8769900 [details] [diff] [review]:
-----------------------------------------------------------------

Why not just use os.path.normcase?

(cc-merge is not coming quickly enough...)
Attachment #8769900 - Flags: feedback?(mh+mozilla)
Comment on attachment 8769407 [details] [diff] [review]
proposed patch (v1)

Review of attachment 8769407 [details] [diff] [review]:
-----------------------------------------------------------------

I'm pretty sure I've said it in the past: just use os.path.normcase for path and topsrcdir in is_read_allowed, and other relevant places.
Attachment #8769407 - Flags: review?(mh+mozilla) → review-
Attached patch c-c patch (v3) (obsolete) — Splinter Review
removed debug comment.
Attachment #8769900 - Attachment is obsolete: true
Attachment #8769900 - Flags: review?(Pidgeot18)
Attachment #8769947 - Flags: review?(Pidgeot18)
(In reply to Mike Hommey [:glandium] from comment #41)
> Comment on attachment 8769900 [details] [diff] [review]
> c-c patch (v2)
> 
> Review of attachment 8769900 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Why not just use os.path.normcase?
> 
> (cc-merge is not coming quickly enough...)

I tried the following:
TOPSRCDIR := $(shell $(PYTHON) -c "import os; print os.path.normcase(\"$(TOPSRCDIR)\")") 

and got:

c:/Users/cltbld/AppData/Local/Temp/make1496-3.sh: line 1: c:buildsslavec-cbuild/
client.mk: No such file or directory

so I'm probably using it wrong.
(In reply to Edmund Wong (:ewong) from comment #44)
> (In reply to Mike Hommey [:glandium] from comment #41)
> > Comment on attachment 8769900 [details] [diff] [review]
> > c-c patch (v2)
> > 
> > Review of attachment 8769900 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Why not just use os.path.normcase?
> > 
> > (cc-merge is not coming quickly enough...)
> 
> I tried the following:
> TOPSRCDIR := $(shell $(PYTHON) -c "import os; print
> os.path.normcase(\"$(TOPSRCDIR)\")") 
> 
> and got:
> 
> c:/Users/cltbld/AppData/Local/Temp/make1496-3.sh: line 1:
> c:buildsslavec-cbuild/
> client.mk: No such file or directory
> 
> so I'm probably using it wrong.

I don't want it to convert the forward slashes to back slashes, which
is what os.path.normcase() does.
Use mozpath.normcase.
Comment on attachment 8769407 [details] [diff] [review]
proposed patch (v1)

patch not required
Attachment #8769407 - Attachment is obsolete: true
Comment on attachment 8769947 [details] [diff] [review]
c-c patch (v3)

patch no longer required.
Attachment #8769947 - Attachment is obsolete: true
Attachment #8769947 - Flags: review?(Pidgeot18)
The whole issue here is basically in client.mk, 
http://hg.mozilla.org/comm-central/file/tip/client.mk#l41,

$(CURDIR) depends on how I change to that build directory.  In
the past, it was ok; but post-http://hg.mozilla.org/mozilla-central/rev/49f9aa2b50f0,
the case of $(CURDIR) matters.

while my c-c patch works (and ensures that in the Windows environment,
the TOPSRCDIR uses a lower-case drive), it's not necessary; but, ftr,
this is an issue that someone else could hit.

so, the solution is to do a :

cd c:\<full path to build dir>
<build command>
Anyway... closing this as WFM.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.