FaviconView: Exit early in updateImageInternal()

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Follow-up from bug 1228680:

I just saw that one of my patches removed an early return in updateImageInternal():
https://hg.mozilla.org/mozilla-central/rev/027b026256c0#l6.54

This wasn't intentional and we should restore the old behavior.
(Assignee)

Comment 1

3 years ago
Created attachment 8751396 [details]
MozReview Request: Bug 1272021 - FaviconView.updateImageInternal(): Exit early if bitmap is null. r?ahunt

Review commit: https://reviewboard.mozilla.org/r/52003/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52003/
Attachment #8751396 - Flags: review?(ahunt)
Comment on attachment 8751396 [details]
MozReview Request: Bug 1272021 - FaviconView.updateImageInternal(): Exit early if bitmap is null. r?ahunt

https://reviewboard.mozilla.org/r/52003/#review48873

Sorry I forgot to press "Publish Review" yesterday...
Attachment #8751396 - Flags: review?(ahunt) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/e9b22ce9e0296b451dd3dd84ee7f054ccdc381b5
Bug 1272021 - FaviconView.updateImageInternal(): Exit early if bitmap is null. r=ahunt

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e9b22ce9e029
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.