1272027 - deploy loop-server "0.21.1" to Stage with new keys

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Daniel Maher [:phrawzty]]

Chapter 47 in the continuing saga of the key rotation adventure.  We can now move on to the following steps:

(In reply to Rémy Hubscher (:natim) from bug 1269745)
> - Now do another deploy to stage with the latest version (Remy's fix) AND
> the new keys that will go out for production.
> - QA then creates more rooms, tests both the new rooms and the previously
> created rooms.
> - We then ask Tokbox to invalidate the temporary keys (we don't have an
> option to do this)
> - QA then tests again the previously created rooms that should carry on
> working.

I propose Tuesday 17 May 2016 for this deployment.  Please chime in with a yay/nay as appropriate. :)

Comment 1

[Daniel Maher [:phrawzty]]

07:52:42 < Standard8> phrawzty: if you NI me, I’ll fill in extra detail tomorrow

Comment 2

[Mark Banner (:standard8)]

------------------
RELEASE NOTES
------------------
https://github.com/mozilla-services/loop-server/releases

COMPARISONS
https://github.com/mozilla-services/loop-server/compare/0.19.4...0.20.0
https://github.com/mozilla-services/loop-server/compare/0.20.0...0.20.1
https://github.com/mozilla-services/loop-server/compare/0.20.1...0.21.0

TAGS
https://github.com/mozilla-services/loop-server/releases/tag/0.21.0
https://github.com/mozilla-services/loop-server/commit/a907cccf87472986b1e4a8175e716ca3e713f9b3

For the keys, we need to update the stage config with the keys I already sent to Daniel:

Nightly/Aurora API Key: 45552132
Production API Key: 45552152

Note: the clients don't actually use the nightly/aurora keys at the moment, but this is something we'll fix on the client side once we've released the new server version.

Daniel: Remy has already said that if we need to backout libsodium again, we can do a .1 release.

Comment 3

[Chris Hartjes [:grumpy][:chartjes]]

I'm available to do a deploy on Wednesday morning my time (9AM EDT)

Comment 4

[Daniel Maher [:phrawzty]]

(In reply to Mark Banner (:standard8) from comment #2)
> Daniel: Remy has already said that if we need to backout libsodium again, we
> can do a .1 release.

We still need to use the older version of libsodium.  This has not changed.

(In reply to Chris Hartjes [:grumpy][:chartjes] from comment #3)
> I'm available to do a deploy on Wednesday morning my time (9AM EDT)

Confirmed for 2016-05-18 15:00 UTC.

Comment 5

[Mark Banner (:standard8)]

(In reply to Daniel Maher [:phrawzty] from comment #4)
> (In reply to Mark Banner (:standard8) from comment #2)
> > Daniel: Remy has already said that if we need to backout libsodium again, we
> > can do a .1 release.
> 
> We still need to use the older version of libsodium.  This has not changed.

Remy, can you help here please?

Comment 6

[Rémy Hubscher (:natim)]

I think there is another package to back out do you remember which one it is?

Comment 7

[Rémy Hubscher (:natim)]

loop-server 0.21.1 have been released: https://github.com/mozilla-services/loop-server/releases/tag/0.21.1

Comment 8

[Mark Banner (:standard8)]

(:natim) from comment #7)
> loop-server 0.21.1 have been released:
> https://github.com/mozilla-services/loop-server/releases/tag/0.21.1

Yep, that I think has dropped all the right ones.

Comment 9

[Chris Hartjes [:grumpy][:chartjes]]

======================
PRE-DEPLOYMENT TESTING
======================

Ran configuration check tests using the following expected values:

location =  https://www.mozilla.org/firefox/hello/
root = https://call.stage.mozaws.net
loop_server = https://loop.stage.mozaws.net
loop_server_version = 0.19.4
loop_server_push_server_config = https://loop.stage.mozaws.net/push-server-config
loop_server_push_server_uri = wss://autopush.stage.mozaws.net
loop_fxos_app_name = Hello Stage
feedbackProductName = Loop
privacyWebsiteUrl = https://www.mozilla.org/privacy/firefox-hello/
legalWebsiteUrl = https://www.mozilla.org/about/legal/terms/firefox-hello/
roomsSupportUrl = https://support.mozilla.org/kb/group-conversations-firefox-hello-webrtc
guestSupportUrl = https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode
unsupportedPlatformUrl = https://support.mozilla.org/kb/which-browsers-will-work-firefox-hello-video-chat
learnMoreUrl = https://www.mozilla.org/hello/
homePage = https://github.com/mozilla-services/loop-server/
fakeTokBox = False
fxaOAuth = True
name = mozilla-loop-server
version = 0.19.4

deployment_tests/test_deployment.py::test_header PASSED
deployment_tests/test_deployment.py::test_server_config PASSED
deployment_tests/test_deployment.py::test_server_response PASSED
deployment_tests/test_deployment.py::test_push_server_config PASSED

Placed several calls successfully using loop-server 0.19.4 tag on STAGE
using: Firefox General Release (46.0.1) and Nightly (49.0a1) with 
loop.server set to https://loop.stage.mozaws.net/v0


TEST RESULTS

end-2-end test calls (shared URL) - OK
Video/audio mute/unmute - OK
messaging - OK 
Tab & window-sharing - OK
privacy & ToS links - OK
Feedback screens - OK

Comment 10

[Chris Hartjes [:grumpy][:chartjes]]

======================
POST-DEPLOYMENT TESTING
======================

Ran configuration check tests using the following expected values:

location =  https://www.mozilla.org/firefox/hello/
root = https://call.stage.mozaws.net
loop_server = https://loop.stage.mozaws.net
loop_server_version = 0.21.1
loop_server_push_server_config = https://loop.stage.mozaws.net/push-server-config
loop_server_push_server_uri = wss://autopush.stage.mozaws.net
loop_fxos_app_name = Hello Stage
feedbackProductName = Loop
privacyWebsiteUrl = https://www.mozilla.org/privacy/firefox-hello/
legalWebsiteUrl = https://www.mozilla.org/about/legal/terms/firefox-hello/
roomsSupportUrl = https://support.mozilla.org/kb/group-conversations-firefox-hello-webrtc
guestSupportUrl = https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode
unsupportedPlatformUrl = https://support.mozilla.org/kb/which-browsers-will-work-firefox-hello-video-chat
learnMoreUrl = https://www.mozilla.org/hello/
homePage = https://github.com/mozilla-services/loop-server/
fakeTokBox = False
fxaOAuth = True
name = mozilla-loop-server
version = 0.21.1

deployment_tests/test_deployment.py::test_header PASSED
deployment_tests/test_deployment.py::test_server_config PASSED
deployment_tests/test_deployment.py::test_server_response PASSED
deployment_tests/test_deployment.py::test_push_server_config PASSED

Placed several calls successfully using loop-server 0.19.4 tag on STAGE
using: Firefox General Release (46.0.1) and Nightly (49.0a1) as well as General Release with Beta (47.0.b5) with 
loop.server set to https://loop.stage.mozaws.net/v0


TEST RESULTS

end-2-end test calls (shared URL) - OK
Video/audio mute/unmute - OK
messaging - OK 
Tab & window-sharing - OK
privacy & ToS links - OK
Feedback screens - OK

Verified that two Hello sessions created before the update still functioned as expected.

Comment 11

[Rémy Hubscher (:natim)]

> Verified that two Hello sessions created before the update still functioned as expected.

\o/

Comment 12

[Mark Banner (:standard8)]

I've manually tested the keys on the Nightly/Aurora channel. These currently require code changes - I recently discovered we haven't been using them for a while, we're going to switch back to using them, but I want to get the deploys done first.

To test the channel, I took the latest Loop code and in LoopRooms#create, added a line:

encrypted.channel = "nightly";

just before the hawk request is made. I also tested this with aurora as well.

We initially found a problem - there was a typo on the apiKey on the server. Daniel has now corrected that.

With the code and additional server fix in place, I tested creating a new room and having an e2e conversation using the latest code and latest nightly. I tested with "nightly", "aurora" and no channel specified.

All was fine.

Comment 13

[Chris Hartjes [:grumpy][:chartjes]]

QA approves the deployment