127205 - setNamedItemNS() in NamedNodeMap doesn't set the item properly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P4)

Description

[Grace Chang]

From Bugzilla Helper:
BuildID:    2001101117

The item in NamedNodeMap is not changed after setting new value by 
setNamedItemNS().
setNamedItemNS() is implemented in 
(content/base/src/nsDOMAttributeMap.cpp)
   nsresult nsDOMAttributeMap::SetNamedItemNS (nsIDOMNode* aArg, nsIDOMNode** 
aReturn)

I think removing the line with :
        attribute->GetPrefix(name);
will fix the problem.


Reproducible: Always

Comment 1

[Fabian Guisset]

CC'ing sicking for his input about the proposed fix.
->DOM Core, P4.
Marking NEW.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Good catch! Yep, that should fix it.

However i'd rather wait a bit and do this in my bigger changes to this class, 
which will fix the many Attr-Node bugs we have today. Reason being that most of 
this code will change anyway at that point. That work will be finished before 
1.0, i promice you.

Comment 3

[Johnny Stenback (:jst)]

Mass-reassigning bugs to [e-mail]

Comment 4

[Peter Van der Beken [:peterv]]

Pfff.

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 131796 [details] [diff] [review]
v1

Heh, good one :-)

sr=jst

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 131796 [details] [diff] [review]
v1

ugh, whatever was i thinking

Comment 8

[Peter Van der Beken [:peterv]]

Checked in.