1272071 - Synced Tabs title label jumps down when navigating to panel

Status: VERIFIED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: sync_jump.mov

STR:

1. Open up the home panelsx
2. Navigate to the Synced Tabs panel without a device connected

Expected
*Synced Tabs title should not move

Actual
*Title jumps down quickly

----

It seems that upon navigating to the view, the default state is to show the subtitle text but then the screen updates right away reflecting no devices connected which causes the jump.

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

check if the completion blocking results in too slow of a render time. There is a slight difference but not much!

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8758879 [details] [review]
PR

Left feedback on the PR!

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8758879 [details] [review]
PR

Adding some more feedback about async-ness of calls and some nits.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8758879 [details] [review]
PR

Looks good - just two minor nits.

Comment 5

[Bryan Munar (:bkmunar)]

https://github.com/mozilla/firefox-ios/pull/1874/commits/ad010d098543eaf077151b8a95ac9d19eab50abc

Comment 6

[Stephan Leroux [:sleroux]]

Missing [needsuplift]. Uplifting since this change needs to be in 5.0.

v5.x ea81f6e505bf63aaedb6996102dc879987175b93

Comment 7

[Simon Basca [:SimonB]]

Tested on 5.0b10.
The Synced Tabs title label no longer jumps down when navigating to panel.