Closed Bug 1272086 Opened 4 years ago Closed 2 years ago

Remove MOZ_SOCIAL configure flags

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: chmanchester, Assigned: standard8)

References

Details

Attachments

(1 file)

Moving flags to Python configure in bug 1257326, we're moving MOZ_SOCIAL to a flag that defaults to true but is unset for android builds, which is consistent with the way things are done in autoconf.

This flag looks desktop specific, we should move it to browser/moz.configure if possible.
I'd go further and suggest that if it's indeed browser specific, its support files should move out of toolkit/.
Shane, would you have some insight to give?
Flags: needinfo?(mixedpuppy)
Yeah, desktop only, it could move out of toolkit.
Flags: needinfo?(mixedpuppy)
Bug 1388902 and bug 1406193 removed the last bits of the social API. I just noticed that MOZ_SOCIAL is still defined as a configuration item, but is unused:

http://searchfox.org/mozilla-central/search?q=MOZ_SOCIAL&case=false&regexp=false&path=

Hence I think we can drop that now.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Summary: Determine if MOZ_SOCIAL is meant to be set for non-desktop builds and move it to browser/moz.configure if not → Remove MOZ_SOCIAL configure flags
Attachment #8923750 - Flags: review?(core-build-config-reviews)
Comment on attachment 8923750 [details]
Bug 1272086 - Remove now-unused MOZ_SOCIAL configure options.

https://reviewboard.mozilla.org/r/194894/#review200140

Thank you for the patch
Attachment #8923750 - Flags: review+
Attachment #8923750 - Flags: review?(core-build-config-reviews)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a1ecf739615
Remove now-unused MOZ_SOCIAL configure options. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/2a1ecf739615
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.