1272141 - It would be nice if the web-platform-tests-create mach command created intermediate directories

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P3)

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: Bug 1272141 - Make web-platform-tests-create mach command create intermediate directories; r?jgraham

Review commit: https://reviewboard.mozilla.org/r/52031/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52031/

Comment 2

[James Graham [:jgraham]]

Comment on attachment 8751480 [details]
MozReview Request: Bug 1272141 - Make web-platform-tests-create mach command create intermediate directories; r?jgraham

https://reviewboard.mozilla.org/r/52031/#review48917

::: testing/web-platform/mach_commands.py:208
(Diff revision 1)
>              template += self.template_body_reftest % args
>              if kwargs["wait"]:
>                  template += self.template_body_reftest_wait
>          else:
>              template += self.template_body_th
> +        os.makedirs(os.path.dirname(path))

This will throw if the directory alrady exists, I think.

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8751480 [details]
MozReview Request: Bug 1272141 - Make web-platform-tests-create mach command create intermediate directories; r?jgraham

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52031/diff/1-2/

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8751480 [details]
MozReview Request: Bug 1272141 - Make web-platform-tests-create mach command create intermediate directories; r?jgraham

https://reviewboard.mozilla.org/r/52031/#review49091

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6293e3a7c74f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6293e3a7c74f