Closed Bug 1272141 Opened 5 years ago Closed 5 years ago

It would be nice if the web-platform-tests-create mach command created intermediate directories

Categories

(Testing :: web-platform-tests, defect, P3)

Version 3
defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8751480 [details]
MozReview Request: Bug 1272141 - Make web-platform-tests-create mach command create intermediate directories; r?jgraham

https://reviewboard.mozilla.org/r/52031/#review48917

::: testing/web-platform/mach_commands.py:208
(Diff revision 1)
>              template += self.template_body_reftest % args
>              if kwargs["wait"]:
>                  template += self.template_body_reftest_wait
>          else:
>              template += self.template_body_th
> +        os.makedirs(os.path.dirname(path))

This will throw if the directory alrady exists, I think.
Attachment #8751480 - Flags: review?(james)
Comment on attachment 8751480 [details]
MozReview Request: Bug 1272141 - Make web-platform-tests-create mach command create intermediate directories; r?jgraham

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52031/diff/1-2/
Attachment #8751480 - Flags: review?(james)
Comment on attachment 8751480 [details]
MozReview Request: Bug 1272141 - Make web-platform-tests-create mach command create intermediate directories; r?jgraham

https://reviewboard.mozilla.org/r/52031/#review49091
Attachment #8751480 - Flags: review?(james) → review+
https://hg.mozilla.org/mozilla-central/rev/6293e3a7c74f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.