Remove hacks that allow VS2013 builds running on Windows XP SP2

NEW
Unassigned

Status

3 years ago
10 months ago

People

(Reporter: emk, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
VS2015 does not require this hack. It will become a dead weight once VS2013 support has been dropped.
(Reporter)

Updated

3 years ago
No longer blocks: 1186064
Depends on: 1186064
Bug 1023941, parts 1 through 5, were mostly backed out by bug 1035125, parts 1 through 5.

As far as I know the only bits remaining are some dead defines:
https://dxr.mozilla.org/mozilla-central/search?q=XRE_DONT_SUPPORT_XPSP2&redirect=false

And this fallout from having both a static and dynamic CRT loaded:
https://hg.mozilla.org/mozilla-central/diff/90c2371af31d/toolkit/xre/nsAppRunner.cpp

I'm a bit scared of removing the latter, even though it's now unnecessary, because it was such a hairy bug to diagnose and fix, and it took a long time to get reported. If we ever go back to a static CRT for firefox.exe, we'd have to go through that process again. Ted, how do you feel about removing it?
Flags: needinfo?(ted)
I'm not a big fan of leaving dead code in, but I agree that leaving ourselves a super-hard-to-diagnose footgun isn't great either. Maybe we can just add a comment in `browser/app/moz.build` with a pointer to the bug saying if you ever set `USE_STATIC_LIBS = True` there, re-apply that fix?
Flags: needinfo?(ted)

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.