Closed Bug 1272237 Opened 9 years ago Closed 8 years ago

Support night mode on iOS

Categories

(Firefox for iOS :: Theme & Visual Design, defect, P1)

Product:
Firefox for iOS
Component:
Theme & Visual Design
Platform:
Other
iOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.22
Tracking Flags:
Tracking Status
fxios 8.0+ ---
fxios-v5.0 --- fixed
fxios-v6.0 --- fixed

People

(Reporter: dxue, Assigned: lyang, Mentored)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [MobileCore])

Attachments

(1 file)

Pull request
48 bytes, text/x-github-pull-request
jhugman
: review+
jhugman
: feedback+
Details | Review
No description provided.
Blocks: 1227832
Attached file Pull request —
Assignee: nobody → dxue
Mentor: jhugman
Comment on attachment 8751645 [details] [review] Pull request May also be linked to Bug 1272235.
Attachment #8751645 - Flags: feedback?(jhugman)
Added strings for v5.x https://bugzilla.mozilla.org/show_bug.cgi?id=1279500 How is this going otherwise?
Flags: needinfo?(dxue)
(In reply to James Hugman [:jhugman] [@jhugman] from comment #3) > Added strings for v5.x https://bugzilla.mozilla.org/show_bug.cgi?id=1279500 > > How is this going otherwise? Pull request has updated
Flags: needinfo?(dxue)
Attachment #8751645 - Flags: feedback?(jhugman)
Attachment #8751645 - Flags: review?(jhugman)
Attachment #8751645 - Flags: review?(jhugman)
Comment on attachment 8751645 [details] [review] Pull request I have rebased on master
Attachment #8751645 - Flags: review?(jhugman)
Comment on attachment 8751645 [details] [review] Pull request I've added some comments to PR. You're getting really close. Have a look at the comments, and then r? again.
Attachment #8751645 - Flags: review?(jhugman) → feedback+
Status: NEW → ASSIGNED
Comment on attachment 8751645 [details] [review] Pull request update pull request
Attachment #8751645 - Flags: review?(jhugman)
Comment on attachment 8751645 [details] [review] Pull request Good job, well done. I've added some comments in the PR, including asking for some followups.
Attachment #8751645 - Flags: review?(jhugman) → review+
Should be uplifted with Bug 1281679.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
Depends on: 1281761
Depends on: 1281776
v5.x a94f621
status-fxios-v5.0: --- → fixed
status-fxios-v6.0: --- → fixed
Whiteboard: [needsuplift]
This bug seems to cause regressions with styling on pages, see bug https://bugzilla.mozilla.org/show_bug.cgi?id=1281761
Depends on: 1282715
Depends on: 1311898
Because we plan to ship this for 8.0, I am reopening this bug. Not clear if work has to be done other than enabling the feature though.
Status: RESOLVED → REOPENED
Iteration: --- → 1.22
tracking-fxios: --- → 8.0+
Resolution: FIXED → ---
Whiteboard: [MobileCore]
Assignee: dxue → lyang
Depends on: 1365924
Confusing state here with an open bug with dependencies with a landed feature hopping straight to beta
Priority: -- → P1
Enabled on master and 8.x
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → FIXED
Depends on: 1372525
Depends on: 1372570
Depends on: 1380586
Blocks: 1508273
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: