If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Equality operators for Register64

RESOLVED FIXED in Firefox 49

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
"Register" can be compared for equality; "Register64" should have this ability too (and I need this functionality for the Wasm baseline so we might as well land it).
(Assignee)

Comment 1

a year ago
Created attachment 8751643 [details] [diff] [review]
Register64 equality operators
Attachment #8751643 - Flags: review?(bbouvier)
Comment on attachment 8751643 [details] [diff] [review]
Register64 equality operators

Review of attachment 8751643 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

::: js/src/jit/Registers.h
@@ +129,5 @@
> +    bool operator ==(Register64 other) const {
> +        return high == other.high && low == other.low;
> +    }
> +    bool operator !=(Register64 other) const {
> +        return high != other.high || low != other.low;

I see that the operator!= for Register follows the same logic, but as the condition is slightly more complicated, feel free to rewrite this as !operator==(other), if you want too.
Attachment #8751643 - Flags: review?(bbouvier) → review+
(Assignee)

Comment 3

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ed0dea5f446d1d305285d89a7a5b26adfb1f202
Bug 1272252 - Register64 equality operators. r=bbouvier

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6ed0dea5f446
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.