1272277 - Device resets lead to constant full-page invalidation

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Device resets throw us into bizzaro invalidate-all-the-things-all-the-time mode.

Becomes very obvious forcing a device reset with paint flashing on.

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: 1272277-1.patch

If the current device counter is different from the last count that ClientLayerManager saw, then invalidate everything.

Except the last count was never updated, causing us to hit this every time. Oops.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: 1272277-2.patch

That led to breakage when switching back from the MS Basic Render Driver to actual hardware. It seems that not all instances of the Basic Renderer ID3D11Device on the system know about the reset at the same time -- that is, calling GetDeviceRemovedReason on similar ID3D11Devices in two different processes around the same time can return different results.

So force a content device reset when the parent compositor is updated.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/beb7305d0d5f
https://hg.mozilla.org/integration/mozilla-inbound/rev/02cb93a3dbf1

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/beb7305d0d5f
https://hg.mozilla.org/mozilla-central/rev/02cb93a3dbf1