1272355 - hide reassigned/invalid/downstreamed alerts by default

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

if alerts are reassigned/downstream/invalid, please hide them by default!

an example is this:
https://treeherder.mozilla.org/perf.html#/alerts?id=1142

Comment 1

[William Lachance (:wlach)]

Agreed. See also bug 1268247 and bug 1247028, which also deal with filtering and display.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] rwood-moz:bug1272355 > mozilla:master

Comment 3

[Robert Wood [:rwood]]

Comment on attachment 8796284 [details] [review]
[treeherder] rwood-moz:bug1272355 > mozilla:master

Oh wait, perhaps we should list the ids of the hidden reassigned/invalid alerts at the bottom, similar to how the downstream ones are listed. Cancelling review until I add that.

Comment 4

[William Lachance (:wlach)]

Yeah, we need to be a bit careful about this:

1. "Reassigned from" alerts should still be shown (it's just "reassigned to" alerts that we don't care about)
2. We should probably have some kind of filter box (similiar to "Hide improvements", but selected by default) to show/hide these alerts.

Comment 5

[Robert Wood [:rwood]]

(In reply to William Lachance (:wlach) from comment #4)

Ok thanks Will, I'll do that (makes sense!)

Comment 6

[Robert Wood [:rwood]]

Comment on attachment 8796284 [details] [review]
[treeherder] rwood-moz:bug1272355 > mozilla:master

PR updated - alerts that are reassigned *to* or are downstream to others, are hidden by default; added checkboxes to show these hidden alerts.

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8796284 [details] [review]
[treeherder] rwood-moz:bug1272355 > mozilla:master

Sorry for the delay reviewing this. See github pr for comments. Please re-r? when ready. :)

Comment 8

[Robert Wood [:rwood]]

Comment on attachment 8796284 [details] [review]
[treeherder] rwood-moz:bug1272355 > mozilla:master

Thanks Will, PR updated: changed to a single check box for hiding, which is turned on by default.

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8796284 [details] [review]
[treeherder] rwood-moz:bug1272355 > mozilla:master

Excellent, thanks!

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d446f6a8e5c2b114fb308f2de98ef83cd59e393c
Bug 1272355 - Hide invalid/reassigned/downstream alerts by default (#1882)