Closed
Bug 1272397
Opened 8 years ago
Closed 8 years ago
use AppendElements in GetColorsForProperty
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
|
1.35 KB,
patch
|
tromey
:
review+
|
Details | Diff | Splinter Review |
Creating an array of exactly the size that we need is faster than possibly going through several rounds of reallocation and copying.
|
Assignee | |
Comment 1•8 years ago
|
||
Tom has modified code around here recently, so why don't we let him review some as well?
Attachment #8751805 -
Flags: review?(ttromey)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8751805 [details] [diff] [review] use AppendElements in GetColorsForProperty Review of attachment 8751805 [details] [diff] [review]: ----------------------------------------------------------------- Thank you. Looks great.
Attachment #8751805 -
Flags: review?(ttromey) → review+
|
||
Updated•8 years ago
|
Whiteboard: btpp-active
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/39496abed3de
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•