Closed Bug 1272397 Opened 4 years ago Closed 4 years ago

use AppendElements in GetColorsForProperty

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

Creating an array of exactly the size that we need is faster than
possibly going through several rounds of reallocation and copying.
Tom has modified code around here recently, so why don't we let him review some
as well?
Attachment #8751805 - Flags: review?(ttromey)
Comment on attachment 8751805 [details] [diff] [review]
use AppendElements in GetColorsForProperty

Review of attachment 8751805 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.  Looks great.
Attachment #8751805 - Flags: review?(ttromey) → review+
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/39496abed3de
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.