Make TelemetryPingStore.getAllPings return pings in order – earliest to latest

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 49
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(3 attachments)

Comment hidden (typo)
via bug 1270213 comment 24. This lets us try to offload our data before it gets deleted if we run out of space to store pings.
Duplicate of this bug: 1273339
Created attachment 8753144 [details]
MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53036/
Attachment #8753144 - Flags: review?(s.kaspari)
Attachment #8753145 - Flags: review?(s.kaspari)
Attachment #8753146 - Flags: review?(s.kaspari)
Created attachment 8753145 [details]
MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53038/
Created attachment 8753146 [details]
MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53040/
Comment on attachment 8753144 [details]
MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53036/diff/1-2/
Attachment #8753144 - Attachment description: MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=sebastian → MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt
Attachment #8753145 - Attachment description: MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=sebastian → MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt
Attachment #8753146 - Attachment description: MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=sebastian → MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt
Attachment #8753144 - Flags: review?(s.kaspari) → review?(ahunt)
Attachment #8753145 - Flags: review?(s.kaspari) → review?(ahunt)
Attachment #8753146 - Flags: review?(s.kaspari) → review?(ahunt)
Comment on attachment 8753145 [details]
MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53038/diff/1-2/
Comment on attachment 8753146 [details]
MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53040/diff/1-2/

Comment 9

3 years ago
Comment on attachment 8753144 [details]
MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt

https://reviewboard.mozilla.org/r/53036/#review50382
Attachment #8753144 - Flags: review?(ahunt) → review+

Comment 10

3 years ago
Comment on attachment 8753145 [details]
MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt

https://reviewboard.mozilla.org/r/53038/#review50386
Attachment #8753145 - Flags: review?(ahunt) → review+

Updated

3 years ago
Attachment #8753146 - Flags: review?(ahunt) → review+

Comment 11

3 years ago
Comment on attachment 8753146 [details]
MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt

https://reviewboard.mozilla.org/r/53040/#review50406

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/318ef7e93e40
https://hg.mozilla.org/mozilla-central/rev/aba775e7b89c
https://hg.mozilla.org/mozilla-central/rev/536b16b34e0f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.