Closed Bug 1272503 Opened 4 years ago Closed 3 years ago

make alerting for changes in num_constructors more agressive.

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: tbsaunde, Unassigned)

Details

Attachments

(1 file)

There shouldn't be any noise in this number, either a patch adds or removes
constructors or it doesn't.  Choosing 0.25% is kind of arbitrary, but it should
be good enough since it will make us alert for an increase of one constructor
so long as we have less than 400 constructors, and currently we have 98.
Attachment #8751952 - Flags: review?(wlachance)
Attachment #8751952 - Flags: feedback?(fbraun+bzlite)
Comment on attachment 8751952 [details] [diff] [review]
make alerting for changes in num_constructors more agressive.

I have no idea what this patch is doing nor have I ever looked at our build config before.
I can't provide feedback here.
Maybe you caught the wrong guy?
Attachment #8751952 - Flags: feedback?(fbraun+bzlite)
Comment on attachment 8751952 [details] [diff] [review]
make alerting for changes in num_constructors more agressive.

Review of attachment 8751952 [details] [diff] [review]:
-----------------------------------------------------------------

The perfherder part looks fine, but I really don't know what num_ctors represents. :) Redirecting review to nfroyd.
Attachment #8751952 - Flags: review?(wlachance)
Attachment #8751952 - Flags: review?(nfroyd)
Attachment #8751952 - Flags: feedback+
(In reply to Frederik Braun (via bzlite app) [:freddyb] from comment #2)
> Comment on attachment 8751952 [details] [diff] [review]
> make alerting for changes in num_constructors more agressive.
> 
> I have no idea what this patch is doing nor have I ever looked at our build
> config before.
> I can't provide feedback here.
> Maybe you caught the wrong guy?

yeah, I meant to get froydnj, sorry.
Comment on attachment 8751952 [details] [diff] [review]
make alerting for changes in num_constructors more agressive.

Review of attachment 8751952 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.  Where do these alerts go?  Any place useful?
Attachment #8751952 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #5)
> Sure.  Where do these alerts go?  Any place useful?

You should be able to sheriff them through the perfherder alerts view:

https://treeherder.mozilla.org/perf.html#/alerts?status=0&framework=2

Let me know if you want staff permissions, which will let you triage status and link alerts to bugs.
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ecfb9c2743
make alerting for changes in num_constructors more agressive r=froydnj f=wlach
https://hg.mozilla.org/mozilla-central/rev/a0ecfb9c2743
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.