1272503 - make alerting for changes in num_constructors more agressive.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Trevor Saunders (:tbsaunde)]

There shouldn't be any noise in this number, either a patch adds or removes
constructors or it doesn't.  Choosing 0.25% is kind of arbitrary, but it should
be good enough since it will make us alert for an increase of one constructor
so long as we have less than 400 constructors, and currently we have 98.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: make alerting for changes in num_constructors more agressive.

Comment 2

[u540588]

Comment on attachment 8751952 [details] [diff] [review]
make alerting for changes in num_constructors more agressive.

I have no idea what this patch is doing nor have I ever looked at our build config before.
I can't provide feedback here.
Maybe you caught the wrong guy?

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8751952 [details] [diff] [review]
make alerting for changes in num_constructors more agressive.

Review of attachment 8751952 [details] [diff] [review]:
-----------------------------------------------------------------

The perfherder part looks fine, but I really don't know what num_ctors represents. :) Redirecting review to nfroyd.

Comment 4

[Trevor Saunders (:tbsaunde)]

(In reply to Frederik Braun (via bzlite app) [:freddyb] from comment #2)
> Comment on attachment 8751952 [details] [diff] [review]
> make alerting for changes in num_constructors more agressive.
> 
> I have no idea what this patch is doing nor have I ever looked at our build
> config before.
> I can't provide feedback here.
> Maybe you caught the wrong guy?

yeah, I meant to get froydnj, sorry.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8751952 [details] [diff] [review]
make alerting for changes in num_constructors more agressive.

Review of attachment 8751952 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.  Where do these alerts go?  Any place useful?

Comment 6

[William Lachance (:wlach)]

(In reply to Nathan Froyd [:froydnj] from comment #5)
> Sure.  Where do these alerts go?  Any place useful?

You should be able to sheriff them through the perfherder alerts view:

https://treeherder.mozilla.org/perf.html#/alerts?status=0&framework=2

Let me know if you want staff permissions, which will let you triage status and link alerts to bugs.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ecfb9c2743
make alerting for changes in num_constructors more agressive r=froydnj f=wlach

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0ecfb9c2743