Closed
Bug 1272529
Opened 9 years ago
Closed 9 years ago
Socorro UI should show units for Uptime
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozbugz, Assigned: peterbe)
Details
Attachments
(2 files)
In crash reports, the "Uptime" row is just showing a number.
I assume it's milliseconds.
Maybe I could be sure by asking the right people or looking at the code, but to avoid wasting my time, and the time of future lazy and/or forgetful developers like me :-) , why not just show the units on the crash report page?
E.g. "Uptime (ms)" or similar.
| Assignee | ||
Comment 1•9 years ago
|
||
Given how few people use a mobile phone (that doesn't have a mouse) to read crash-stats, why don't we make a tooltip that shows the number in a human readable format?
| Assignee | ||
Comment 2•9 years ago
|
||
I have a prototype for this. I think it looks pretty good.
On contemplation I like this much better than *relying* on tooltips.
The prototype works for timestamps, durations and file sizes. It's defensively coded and entirely in JavaScript. So it can be attached to any column simply by predicting if it's a timestamp, duration or a file size.
We could consider prefixing it with the word "approximately" since there's often going to be rounding.
| Assignee | ||
Comment 3•9 years ago
|
||
Adrian, Can you validate my prototype (based on looking at the screenshot) before I finish it?
Flags: needinfo?(adrian)
| Reporter | ||
Comment 4•9 years ago
|
||
Peter:
First, thank you for looking into this.
And thank you for not making a tooltip, I prefer to just see the information without having to hover. :-)
Your prototype looks good to me, very easy to read.
Looks like my assumption was wrong: Uptime is in seconds, good to know!
May I still request/suggest that, as well as your prototype, you show the actual units for "Uptime", e.g. "Uptime (s)"?
It would show the exact unit for the number, giving an idea of the precision. And it wouldn't take much actual space, as most other row headers are wider already.
Or maybe "Uptime | 1986s (33 minutes)" if it's easier.
Your prototype gives me another idea: It'd be great to see user-friendly date&time displays for unix timestamps, e.g.:
"CrashTime | 1458454027 (Sun, 20 Mar 2016 06:07:07 GMT)". If you can do it at the same time, please go for it, otherwise I'm happy to open another bug for later consideration (or rejection).
Comment 5•9 years ago
|
||
That looks great! I would add "seconds" right after the value, before the human friendly version, like we do for the other time values. So it would look like this:
Uptime | 1986 seconds (33 minutes)
Flags: needinfo?(adrian)
| Assignee | ||
Comment 6•9 years ago
|
||
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → peterbe
Comment 7•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/f116d5ab362621f3d5c67b799459a806a83cbd99
fixes bug 1272529 - humanize durations and filesizes on report index (#3349)
r=adngdb
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•