Closed
Bug 1272531
Opened 8 years ago
Closed 8 years ago
Advanced panel does not occupy full content width in about:net/certerror.
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
People
(Reporter: nhnt11, Assigned: nhnt11)
References
Details
(Keywords: regression, Whiteboard: [fxprivacy])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Gijs
:
review+
gchang
:
approval-mozilla-aurora+
gchang
:
approval-mozilla-beta+
|
Details |
Regression from bug 1246162, the advanced panel container needs width: 100%.
Updated•8 years ago
|
status-firefox48:
--- → affected
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/52555/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/52555/
Attachment #8752362 -
Flags: review?(gijskruitbosch+bugs)
Updated•8 years ago
|
Attachment #8752362 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8752362 [details] MozReview Request: Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs https://reviewboard.mozilla.org/r/52555/#review49694
Updated•8 years ago
|
Updated•8 years ago
|
QA Contact: paul.silaghi
Updated•8 years ago
|
Flags: qe-verify? → qe-verify+
Comment 4•8 years ago
|
||
We could still uplift this to aurora for sure. Maybe beta.
status-firefox50:
--- → affected
tracking-firefox48:
--- → +
tracking-firefox49:
--- → +
tracking-firefox50:
--- → +
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6e61bbb4c032837e3874f9f6bbe60381b7e6ce34 Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8752362 [details] MozReview Request: Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs Approval Request Comment [Feature/regressing bug #]: Regressed by bug 1246162 [User impact if declined]: Advanced panel in error page UI isn't the right size, looks odd. [Describe test coverage new/current, TreeHerder]: None [Risks and why]: Very low, one CSS rule added to widen the container. [String/UUID change made/needed]: None
Flags: needinfo?(nhnt11)
Attachment #8752362 -
Flags: approval-mozilla-beta?
Attachment #8752362 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8752362 [details] MozReview Request: Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs This patch fixes a regression. Take it in 48 beta 4 and aurora.
Attachment #8752362 -
Flags: approval-mozilla-beta?
Attachment #8752362 -
Flags: approval-mozilla-beta+
Attachment #8752362 -
Flags: approval-mozilla-aurora?
Attachment #8752362 -
Flags: approval-mozilla-aurora+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6e61bbb4c032
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•8 years ago
|
Iteration: --- → 50.2 - Jul 4
Priority: P3 → P1
Comment 9•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/cc1f8d92df30 https://hg.mozilla.org/releases/mozilla-beta/rev/39023f2bbf6e
Comment 10•8 years ago
|
||
Verified fixed FX 50.0a1 (2016-06-29), 49.0a2 (2016-06-29) Win 7
Comment 11•8 years ago
|
||
Verified fixed FX 48b7 Win 7
You need to log in
before you can comment on or make changes to this bug.
Description
•