Closed Bug 1272531 Opened 8 years ago Closed 8 years ago

Advanced panel does not occupy full content width in about:net/certerror.

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox48 + verified
firefox49 + verified
firefox50 + verified

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

(Keywords: regression, Whiteboard: [fxprivacy])

Attachments

(1 file)

Regression from bug 1246162, the advanced panel container needs width: 100%.
Blocks: 1246162
Attachment #8752362 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8752362 [details]
MozReview Request: Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs

https://reviewboard.mozilla.org/r/52555/#review49694
Blocks: 1216897
Flags: qe-verify?
Priority: -- → P3
QA Contact: paul.silaghi
Flags: qe-verify? → qe-verify+
r+'d patch, ready to land?
Flags: needinfo?(nhnt11)
We could still uplift this to aurora for sure. Maybe beta.
https://hg.mozilla.org/integration/fx-team/rev/6e61bbb4c032837e3874f9f6bbe60381b7e6ce34
Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs
Comment on attachment 8752362 [details]
MozReview Request: Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs

Approval Request Comment
[Feature/regressing bug #]: Regressed by bug 1246162
[User impact if declined]: Advanced panel in error page UI isn't the right size, looks odd.
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Very low, one CSS rule added to widen the container.
[String/UUID change made/needed]: None
Flags: needinfo?(nhnt11)
Attachment #8752362 - Flags: approval-mozilla-beta?
Attachment #8752362 - Flags: approval-mozilla-aurora?
Comment on attachment 8752362 [details]
MozReview Request: Bug 1272531 - Make advanced panel in about:neterror stretch to fill content width. r=Gijs

This patch fixes a regression. Take it in 48 beta 4 and aurora.
Attachment #8752362 - Flags: approval-mozilla-beta?
Attachment #8752362 - Flags: approval-mozilla-beta+
Attachment #8752362 - Flags: approval-mozilla-aurora?
Attachment #8752362 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/6e61bbb4c032
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Iteration: --- → 50.2 - Jul 4
Priority: P3 → P1
Verified fixed FX 50.0a1 (2016-06-29), 49.0a2 (2016-06-29) Win 7
Status: RESOLVED → VERIFIED
Verified fixed FX 48b7 Win 7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: