Closed Bug 1272606 Opened 4 years ago Closed 4 years ago

mail: convert all in-tree style sheets logical properties from -moz-padding-start etc. to padding-inline-start etc.

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 49.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Bug 1111440 is landing and we should follow as we don't know how long the -moz prefixes are working.
This patch was generated by the command from bug Bug 1111440:
  find . -name "*.css" -exec sed -i -f mozpropsub {} \;
in the root of a mozilla-central tree, with the file mozpropsub
containing the contents:
s/-moz-padding-end\>/padding-inline-end/g
s/-moz-padding-start\>/padding-inline-start/g
s/-moz-margin-end\>/margin-inline-end/g
s/-moz-margin-start\>/margin-inline-start/g
s/-moz-border-end\>/border-inline-end/g
s/-moz-border-end-color\>/border-inline-end-color/g
s/-moz-border-end-style\>/border-inline-end-style/g
s/-moz-border-end-width\>/border-inline-end-width/g
s/-moz-border-start\>/border-inline-start/g
s/-moz-border-start-color\>/border-inline-start-color/g
s/-moz-border-start-style\>/border-inline-start-style/g
s/-moz-border-start-width\>/border-inline-start-width/g
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8752138 - Flags: review?(aleth)
Comment on attachment 8752138 [details] [diff] [review]
mail-convert.patch

rs+

Good to get rid of the prefixes. Do you know why the "inline" was added?

The linked bug is leave-open, do you know why?
Attachment #8752138 - Flags: review?(aleth) → review+
(In reply to aleth [:aleth] from comment #2)
> Good to get rid of the prefixes. Do you know why the "inline" was added?

I mean, there's also a margin-block-start. What's the difference? Does one need to differentiate in the conversion?
Blocks: 1111440
I don't know why they used "inline".

From MDN:
The margin-block-start CSS property defines the logical block start margin of an element, which maps to a physical margin depending on the element's writing mode, directionality, and text orientation.

The margin-inline-start CSS property defines the logical inline end margin of an element, which maps to a physical margin depending on the element's writing mode, directionality, and text orientation.

I see no real difference. But margin-block-start is only supported from Gecko 41+ and no other browser.

I think they leave it open because dbaron wrote in comment 4: "Note that there are a few tests that should be fixed up as well, but I'll do that in a later patch."
dbaron posted a new patch with an updated script in bug 1111440:

  find ??* -type f -exec sed -i -f ../mozpropsub {} \;
in the root of the repository, with the file ../mozpropsub containing:
s/-moz-padding-end\>/padding-inline-end/g
s/-moz-padding-start\>/padding-inline-start/g
s/-moz-margin-end\>/margin-inline-end/g
s/-moz-margin-start\>/margin-inline-start/g
s/-moz-border-end\>/border-inline-end/g
s/-moz-border-end-color\>/border-inline-end-color/g
s/-moz-border-end-style\>/border-inline-end-style/g
s/-moz-border-end-width\>/border-inline-end-width/g
s/-moz-border-start\>/border-inline-start/g
s/-moz-border-start-color\>/border-inline-start-color/g
s/-moz-border-start-style\>/border-inline-start-style/g
s/-moz-border-start-width\>/border-inline-start-width/g
s/\<MozPaddingEnd\>/paddingInlineEnd/g
s/\<MozPaddingStart\>/paddingInlineStart/g
s/\<MozMarginEnd\>/marginInlineEnd/g
s/\<MozMarginStart\>/marginInlineStart/g
s/\<MozBorderEnd\>/borderInlineEnd/g
s/\<MozBorderEndColor\>/borderInlineEndColor/g
s/\<MozBorderEndStyle\>/borderInlineEndStyle/g
s/\<MozBorderEndWidth\>/borderInlineEndWidth/g
s/\<MozBorderStart\>/borderInlineStart/g
s/\<MozBorderStartColor\>/borderInlineStartColor/g
s/\<MozBorderStartStyle\>/borderInlineStartStyle/g
s/\<MozBorderStartWidth\>/borderInlineStartWidth/g

This updated the files in not themes directories.
Attachment #8752482 - Flags: review?(aleth)
Attachment #8752482 - Flags: review?(aleth) → review+
http://hg.mozilla.org/comm-central/rev/f340020a8caf
http://hg.mozilla.org/comm-central/rev/02e154545225
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
You need to log in before you can comment on or make changes to this bug.