Closed Bug 1272684 Opened 4 years ago Closed 4 years ago

Remove PlacesUtils.promiseUpdatePlace as it has been replaced with PlacesUtils.history.insert

Categories

(Toolkit :: Places, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Iteration:
50.1 - Jun 20
Tracking Status
firefox50 --- fixed

People

(Reporter: bsilverberg, Assigned: bsilverberg)

References

Details

Attachments

(1 file)

Once `insert` lands in History.jsm, deprecate PlacesUtils.promiseUpdatePlace in favor of PlacesUtils.history.insert.
Assignee: nobody → bob.silverberg
Status: NEW → ASSIGNED
Depends on: 1265836
Priority: -- → P3
Blocks: 1272686
No longer blocks: 1272686
I took a quick look at add-ons and looks like this is not used... I guess we can just remove it instead of only deprecating it.
Iteration: --- → 49.2 - May 23
Yeah, I don't see it being used anywhere in the tree. So we can just delete the code for it and it's done?
Flags: needinfo?(mak77)
Yes!
Flags: needinfo?(mak77)
Summary: Deprecate PlacesUtils.promiseUpdatePlace in favor of PlacesUtils.history.insert → Remove PlacesUtils.promiseUpdatePlace as it has been replaced with PlacesUtils.history.insert
Iteration: 49.2 - May 23 → 50.1
Comment on attachment 8761566 [details]
Bug 1272684 - Remove PlacesUtils.promiseUpdatePlace as it has been replaced with PlacesUtils.history.insert,

https://reviewboard.mozilla.org/r/58668/#review56326

Thank you!
Attachment #8761566 - Flags: review?(mak77) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/2ebc739da7e9
Remove PlacesUtils.promiseUpdatePlace as it has been replaced with PlacesUtils.history.insert, r=mak
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2ebc739da7e9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.