unneeded null checks in attribute mapping / rule mapping functions

RESOLVED FIXED in mozilla1.6alpha

Status

()

P3
normal
RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.6alpha
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(2 attachments)

There are lots of unneeded null checks in attribute mapping functions (and
struct mapping functions?), dating back to when hyatt was rewriting things and
they were only partly written.  We should remove these (and make sure the caller
null checks the allocations before continuing).
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.1beta
Should do this at the same time as bug 107100.
Blocks: 107100
In particular, I think all the null checks should be replaced by SID checks (if
the SID checks aren't already there).  There's no need for null checks since
there's stack allocation, and SID checks mean we do less work.
Summary: unneeded null checks in attribute mapping functions → unneeded null checks in attribute mapping / rule mapping functions
Target Milestone: mozilla1.1beta → mozilla1.2alpha
Target Milestone: mozilla1.2alpha → Future
Target Milestone: Future → mozilla1.5beta
Created attachment 129488 [details] [diff] [review]
patch (diff -u)

This contains the fix for this bug (which might let us move towards a
blob-allocation system for the rule data structs), plus a little cleanup in
nsHTMLTableCellElement (which includes an ordering fix for
WalkContentStyleRules -- more specific comes first, although the current code
doesn't have any conflicts), plus the patch for bug 214077, which I didn't want
to bother separating.
Created attachment 129489 [details] [diff] [review]
patch (diff -uw, for review)
Attachment #129489 - Flags: superreview?(bz-vacation)
Attachment #129489 - Flags: review?(bz-vacation)
Whiteboard: [patch]
Target Milestone: mozilla1.5beta → mozilla1.6alpha
Comment on attachment 129489 [details] [diff] [review]
patch (diff -uw, for review)

r+sr=bzbarsky
Attachment #129489 - Flags: superreview?(bz-vacation)
Attachment #129489 - Flags: superreview+
Attachment #129489 - Flags: review?(bz-vacation)
Attachment #129489 - Flags: review+
Fix checked in to trunk, 2003-09-10 18:34 -0700.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.