There are lots of unneeded null checks in attribute mapping functions (and struct mapping functions?), dating back to when hyatt was rewriting things and they were only partly written. We should remove these (and make sure the caller null checks the allocations before continuing).
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.1beta
In particular, I think all the null checks should be replaced by SID checks (if the SID checks aren't already there). There's no need for null checks since there's stack allocation, and SID checks mean we do less work.
Summary: unneeded null checks in attribute mapping functions → unneeded null checks in attribute mapping / rule mapping functions
Target Milestone: mozilla1.1beta → mozilla1.2alpha
Target Milestone: mozilla1.2alpha → Future
Target Milestone: Future → mozilla1.5beta
Created attachment 129488 [details] [diff] [review] patch (diff -u) This contains the fix for this bug (which might let us move towards a blob-allocation system for the rule data structs), plus a little cleanup in nsHTMLTableCellElement (which includes an ordering fix for WalkContentStyleRules -- more specific comes first, although the current code doesn't have any conflicts), plus the patch for bug 214077, which I didn't want to bother separating.
Target Milestone: mozilla1.5beta → mozilla1.6alpha
Comment on attachment 129489 [details] [diff] [review] patch (diff -uw, for review) r+sr=bzbarsky
Fix checked in to trunk, 2003-09-10 18:34 -0700.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.