Closed
Bug 1272720
Opened 8 years ago
Closed 8 years ago
Minor fixes to spidermonkey jobs
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(3 files)
546 bytes,
patch
|
Details | Diff | Splinter Review | |
1.40 KB,
patch
|
garndt
:
review+
|
Details | Diff | Splinter Review |
1.07 KB,
patch
|
garndt
:
review+
|
Details | Diff | Splinter Review |
Grab-bag bug of a couple of minor changes.
Assignee | ||
Comment 1•8 years ago
|
||
Looks like I forgot to amend before landing the rest of this. SM-generational is completely redundant now that generational garbage collection is the default (and has been for a few years).
Attachment #8752273 -
Flags: review?(garndt)
Assignee | ||
Comment 2•8 years ago
|
||
My TinderboxPrint: syntax is outdated. I'd like to figure out how to link to the relevant artifact files, but I'll worry about that later.
Attachment #8752274 -
Flags: review?(garndt)
Assignee | ||
Comment 3•8 years ago
|
||
Doh! I fixed one invocation of grep (to use -F instead of -f), but missed the other.
Attachment #8752275 -
Flags: review?(garndt)
Comment 4•8 years ago
|
||
Comment on attachment 8752273 [details] [diff] [review] Remove SM-generational Review of attachment 8752273 [details] [diff] [review]: ----------------------------------------------------------------- I'm not sure if I'm the right person to review this, I'm not sure what this generational file is for
Updated•8 years ago
|
Attachment #8752274 -
Flags: review?(garndt) → review+
Updated•8 years ago
|
Attachment #8752275 -
Flags: review?(garndt) → review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Greg Arndt [:garndt] from comment #4) > Comment on attachment 8752273 [details] [diff] [review] > Remove SM-generational > > Review of attachment 8752273 [details] [diff] [review]: > ----------------------------------------------------------------- > > I'm not sure if I'm the right person to review this, I'm not sure what this > generational file is for Yeah, sorry, I'll just land that one with r=me. I got confused and thought I was removing a dead taskcluster config file, but it's actually dead spidermonkey configuration code.
https://hg.mozilla.org/integration/mozilla-inbound/rev/56f3f15ac01c https://hg.mozilla.org/integration/mozilla-inbound/rev/454c9d81ab6f https://hg.mozilla.org/integration/mozilla-inbound/rev/1873124da728
Updated•8 years ago
|
Attachment #8752273 -
Flags: review?(garndt)
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/56f3f15ac01c https://hg.mozilla.org/mozilla-central/rev/454c9d81ab6f https://hg.mozilla.org/mozilla-central/rev/1873124da728
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•