Closed Bug 1272720 Opened 8 years ago Closed 8 years ago

Minor fixes to spidermonkey jobs

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(3 files)

Grab-bag bug of a couple of minor changes.
Looks like I forgot to amend before landing the rest of this. SM-generational is completely redundant now that generational garbage collection is the default (and has been for a few years).
Attachment #8752273 - Flags: review?(garndt)
My TinderboxPrint: syntax is outdated. I'd like to figure out how to link to the relevant artifact files, but I'll worry about that later.
Attachment #8752274 - Flags: review?(garndt)
Doh! I fixed one invocation of grep (to use -F instead of -f), but missed the other.
Attachment #8752275 - Flags: review?(garndt)
Comment on attachment 8752273 [details] [diff] [review]
Remove SM-generational

Review of attachment 8752273 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if I'm the right person to review this, I'm not sure what this generational file is for
Attachment #8752274 - Flags: review?(garndt) → review+
Attachment #8752275 - Flags: review?(garndt) → review+
(In reply to Greg Arndt [:garndt] from comment #4)
> Comment on attachment 8752273 [details] [diff] [review]
> Remove SM-generational
> 
> Review of attachment 8752273 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm not sure if I'm the right person to review this, I'm not sure what this
> generational file is for

Yeah, sorry, I'll just land that one with r=me. I got confused and thought I was removing a dead taskcluster config file, but it's actually dead spidermonkey configuration code.
Attachment #8752273 - Flags: review?(garndt)
https://hg.mozilla.org/mozilla-central/rev/56f3f15ac01c
https://hg.mozilla.org/mozilla-central/rev/454c9d81ab6f
https://hg.mozilla.org/mozilla-central/rev/1873124da728
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: